diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2020-04-25 14:09:24 +0200 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-05-08 14:13:29 +0900 |
commit | 314d7f897ca02c173fa0e3b3e36c69482f71a358 (patch) | |
tree | 8f15f5083e13cf2617fed454055e6bb953df668a /test | |
parent | b5a0db8be0086f2d245fd77fd48f89e359d71312 (diff) |
Remove `builder` gem requirement for `gem regenerate_index`
This requirement was introduced 14 years ago in
7ce7039b390440754954df5efea619e9f57ef823, and I don't think it's
necessary anymore. I made several tests introducing UTF-8 characters in
gemspec files and generating indexes out of them, and couldn't find any
issues. Gemspecs are read with UTF-8 encoding these days.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3092
Diffstat (limited to 'test')
-rw-r--r-- | test/rubygems/test_gem_commands_generate_index_command.rb | 6 | ||||
-rw-r--r-- | test/rubygems/test_gem_indexer.rb | 6 | ||||
-rw-r--r-- | test/rubygems/test_gem_source.rb | 2 |
3 files changed, 2 insertions, 12 deletions
diff --git a/test/rubygems/test_gem_commands_generate_index_command.rb b/test/rubygems/test_gem_commands_generate_index_command.rb index d8fda32fc0..6b69bcf353 100644 --- a/test/rubygems/test_gem_commands_generate_index_command.rb +++ b/test/rubygems/test_gem_commands_generate_index_command.rb @@ -3,10 +3,6 @@ require 'rubygems/test_case' require 'rubygems/indexer' require 'rubygems/commands/generate_index_command' -unless defined?(Builder::XChar) - warn "generate_index tests are being skipped. Install builder gem." -end - class TestGemCommandsGenerateIndexCommand < Gem::TestCase def setup @@ -83,4 +79,4 @@ class TestGemCommandsGenerateIndexCommand < Gem::TestCase @ui.error end -end if defined?(Builder::XChar) +end diff --git a/test/rubygems/test_gem_indexer.rb b/test/rubygems/test_gem_indexer.rb index d5f28b8814..f20e3c5112 100644 --- a/test/rubygems/test_gem_indexer.rb +++ b/test/rubygems/test_gem_indexer.rb @@ -2,10 +2,6 @@ require 'rubygems/test_case' require 'rubygems/indexer' -unless defined?(Builder::XChar) - warn "Gem::Indexer tests are being skipped. Install builder gem." -end - class TestGemIndexer < Gem::TestCase def setup @@ -360,4 +356,4 @@ class TestGemIndexer < Gem::TestCase refute File.exist?(file), "#{file} exists" end -end if defined?(Builder::XChar) +end diff --git a/test/rubygems/test_gem_source.rb b/test/rubygems/test_gem_source.rb index 24b8edb055..88e89bd192 100644 --- a/test/rubygems/test_gem_source.rb +++ b/test/rubygems/test_gem_source.rb @@ -55,8 +55,6 @@ class TestGemSource < Gem::TestCase end def test_dependency_resolver_set_file_uri - skip 'install builder gem' unless defined? Builder::XChar - Gem::Indexer.new(@tempdir).generate_index source = Gem::Source.new "file://#{@tempdir}/" |