diff options
-rw-r--r-- | lib/rubygems/indexer.rb | 10 | ||||
-rw-r--r-- | lib/rubygems/specification.rb | 8 | ||||
-rw-r--r-- | lib/rubygems/test_case.rb | 6 | ||||
-rw-r--r-- | test/rubygems/test_gem_commands_generate_index_command.rb | 6 | ||||
-rw-r--r-- | test/rubygems/test_gem_indexer.rb | 6 | ||||
-rw-r--r-- | test/rubygems/test_gem_source.rb | 2 |
6 files changed, 3 insertions, 35 deletions
diff --git a/lib/rubygems/indexer.rb b/lib/rubygems/indexer.rb index 4d199868fb..75bd824c9e 100644 --- a/lib/rubygems/indexer.rb +++ b/lib/rubygems/indexer.rb @@ -11,11 +11,6 @@ rescue LoadError # this rubygems + old ruby else # this rubygems + ruby trunk with bundler rescue_exceptions << Bundler::GemfileNotFound end -begin - gem 'builder' - require 'builder/xchar' -rescue *rescue_exceptions -end ## # Top level class for building the gem repository index. @@ -62,11 +57,6 @@ class Gem::Indexer require 'tmpdir' require 'zlib' - unless defined?(Builder::XChar) - raise "Gem::Indexer requires that the XML Builder library be installed:" + - "\n\tgem install builder" - end - options = { :build_modern => true }.merge options @build_modern = options[:build_modern] diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb index bcb5da52a3..9f6cdea8ad 100644 --- a/lib/rubygems/specification.rb +++ b/lib/rubygems/specification.rb @@ -1447,13 +1447,7 @@ class Gem::Specification < Gem::BasicSpecification # HACK the #to_s is in here because RSpec has an Array of Arrays of # Strings for authors. Need a way to disallow bad values on gemspec # generation. (Probably won't happen.) - string = string.to_s - - begin - Builder::XChar.encode string - rescue NameError, NoMethodError - string.to_xs - end + string.to_s end ## diff --git a/lib/rubygems/test_case.rb b/lib/rubygems/test_case.rb index 6e9c50d9a5..bb1ce280a4 100644 --- a/lib/rubygems/test_case.rb +++ b/lib/rubygems/test_case.rb @@ -1544,10 +1544,4 @@ begin rescue LoadError, Gem::LoadError end -begin - gem 'builder' - require 'builder/xchar' -rescue LoadError, Gem::LoadError -end - require 'rubygems/test_utilities' diff --git a/test/rubygems/test_gem_commands_generate_index_command.rb b/test/rubygems/test_gem_commands_generate_index_command.rb index d8fda32fc0..6b69bcf353 100644 --- a/test/rubygems/test_gem_commands_generate_index_command.rb +++ b/test/rubygems/test_gem_commands_generate_index_command.rb @@ -3,10 +3,6 @@ require 'rubygems/test_case' require 'rubygems/indexer' require 'rubygems/commands/generate_index_command' -unless defined?(Builder::XChar) - warn "generate_index tests are being skipped. Install builder gem." -end - class TestGemCommandsGenerateIndexCommand < Gem::TestCase def setup @@ -83,4 +79,4 @@ class TestGemCommandsGenerateIndexCommand < Gem::TestCase @ui.error end -end if defined?(Builder::XChar) +end diff --git a/test/rubygems/test_gem_indexer.rb b/test/rubygems/test_gem_indexer.rb index d5f28b8814..f20e3c5112 100644 --- a/test/rubygems/test_gem_indexer.rb +++ b/test/rubygems/test_gem_indexer.rb @@ -2,10 +2,6 @@ require 'rubygems/test_case' require 'rubygems/indexer' -unless defined?(Builder::XChar) - warn "Gem::Indexer tests are being skipped. Install builder gem." -end - class TestGemIndexer < Gem::TestCase def setup @@ -360,4 +356,4 @@ class TestGemIndexer < Gem::TestCase refute File.exist?(file), "#{file} exists" end -end if defined?(Builder::XChar) +end diff --git a/test/rubygems/test_gem_source.rb b/test/rubygems/test_gem_source.rb index 24b8edb055..88e89bd192 100644 --- a/test/rubygems/test_gem_source.rb +++ b/test/rubygems/test_gem_source.rb @@ -55,8 +55,6 @@ class TestGemSource < Gem::TestCase end def test_dependency_resolver_set_file_uri - skip 'install builder gem' unless defined? Builder::XChar - Gem::Indexer.new(@tempdir).generate_index source = Gem::Source.new "file://#{@tempdir}/" |