diff options
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | thread_pthread.c | 9 |
2 files changed, 12 insertions, 3 deletions
@@ -1,3 +1,9 @@ +Wed Jun 29 06:21:02 2011 Koichi Sasada <ko1@atdot.net> + + * thread_pthread.c (native_stop_timer_thread): skip to close + communication pipe to avoid timing bug (process termination timing). + The communication pipe will closed by OS. + Wed Jun 29 06:09:54 2011 Koichi Sasada <ko1@atdot.net> * error.c (rb_async_bug_errno): async-safe bug report function. diff --git a/thread_pthread.c b/thread_pthread.c index 420a3f4db5..016ee32abb 100644 --- a/thread_pthread.c +++ b/thread_pthread.c @@ -1189,10 +1189,13 @@ native_stop_timer_thread(int close_anyway) /* close communication pipe */ if (close_anyway) { /* TODO: Uninstall all signal handlers or mask all signals. - * This pass is cleaning phase. It is too rare case - * to generate problem, so we remains it in TODO. + * This pass is cleaning phase (terminate ruby process). + * To avoid such race, we skip to close communication + * pipe. OS will close it at process termination. + * It may not good practice, but pragmatic. + * We remain it is TODO. */ - close_communication_pipe(); + /* close_communication_pipe(); */ } } return stopped; |