summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog4
-rw-r--r--ext/bigdecimal/bigdecimal.c4
-rw-r--r--test/bigdecimal/test_bigdecimal.rb1
3 files changed, 7 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index ab24b731ba..67d9f59d90 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+Fri May 7 03:40:58 2010 NARUSE, Yui <naruse@ruby-lang.org>
+
+ * ext/bigdecimal/bigdecimal.c (VpCtoV): fix to check overflow.
+
Thu May 6 22:19:38 2010 NAKAMURA Usaku <usa@ruby-lang.org>
* cont.c: define FIBER_USE_NATIVE only when _WIN32_WINNT >= 0x0400
diff --git a/ext/bigdecimal/bigdecimal.c b/ext/bigdecimal/bigdecimal.c
index ce311a6b12..9a3dec83d8 100644
--- a/ext/bigdecimal/bigdecimal.c
+++ b/ext/bigdecimal/bigdecimal.c
@@ -4033,9 +4033,9 @@ VpCtoV(Real *a, const char *int_chr, U_LONG ni, const char *frac, U_LONG nf, con
while(i < me) {
es = e*((S_INT)BASE_FIG);
e = e * 10 + exp_chr[i] - '0';
- if(es>e*((S_INT)BASE_FIG)) {
+ if(es > (S_INT)(e*BASE_FIG)) {
exponent_overflow = 1;
- e = es;
+ e = es; /* keep sign */
break;
}
++i;
diff --git a/test/bigdecimal/test_bigdecimal.rb b/test/bigdecimal/test_bigdecimal.rb
index 536ec4874c..b266233b20 100644
--- a/test/bigdecimal/test_bigdecimal.rb
+++ b/test/bigdecimal/test_bigdecimal.rb
@@ -25,6 +25,7 @@ class TestBigDecimal < Test::Unit::TestCase
assert_equal( 1, BigDecimal.new("Infinity").infinite?)
assert_equal(-1, BigDecimal.new("-Infinity").infinite?)
assert_equal(true, BigDecimal.new("NaN").nan?)
+ assert_equal( 1, BigDecimal.new("1E11111111111").infinite?)
end
def _test_mode(type)