diff options
| -rw-r--r-- | ChangeLog | 9 | ||||
| -rw-r--r-- | ext/openssl/ossl_ocsp.c | 6 | ||||
| -rw-r--r-- | ext/openssl/ossl_x509attr.c | 6 | ||||
| -rw-r--r-- | ext/openssl/ossl_x509name.c | 7 |
4 files changed, 21 insertions, 7 deletions
@@ -1,3 +1,12 @@ +Fri Aug 29 12:19:12 2008 Nobuyoshi Nakada <nobu@ruby-lang.org> + + * ext/openssl/ossl_x509attr.c (ossl_x509attr_initialize): fix for + initialization of r18168. + + * ext/openssl/ossl_ocsp.c (ossl_ocspreq_initialize): ditto. + + * ext/openssl/ossl_x509name.c (ossl_x509name_initialize): ditto. + Fri Aug 29 11:04:03 2008 NARUSE, Yui <naruse@ruby-lang.org> * encoding.c (rb_enc_compatible): ASCII compatible string and US-ASCII diff --git a/ext/openssl/ossl_ocsp.c b/ext/openssl/ossl_ocsp.c index 6c6b5e8c42..36a3dd7049 100644 --- a/ext/openssl/ossl_ocsp.c +++ b/ext/openssl/ossl_ocsp.c @@ -107,11 +107,13 @@ ossl_ocspreq_initialize(int argc, VALUE *argv, VALUE self) rb_scan_args(argc, argv, "01", &arg); if(!NIL_P(arg)){ - OCSP_REQUEST *req = DATA_PTR(self); + OCSP_REQUEST *req = DATA_PTR(self), *x; arg = ossl_to_der_if_possible(arg); StringValue(arg); p = (unsigned char*)RSTRING_PTR(arg); - if(!d2i_OCSP_REQUEST(&req, &p, RSTRING_LEN(arg)) && (DATA_PTR(self) = req, 1)){ + x = d2i_OCSP_REQUEST(&req, &p, RSTRING_LEN(arg)); + DATA_PTR(self) = req; + if(!x){ ossl_raise(eOCSPError, "cannot load DER encoded request"); } } diff --git a/ext/openssl/ossl_x509attr.c b/ext/openssl/ossl_x509attr.c index a876ed5af2..1f817cdafe 100644 --- a/ext/openssl/ossl_x509attr.c +++ b/ext/openssl/ossl_x509attr.c @@ -92,7 +92,7 @@ static VALUE ossl_x509attr_initialize(int argc, VALUE *argv, VALUE self) { VALUE oid, value; - X509_ATTRIBUTE *attr; + X509_ATTRIBUTE *attr, *x; const unsigned char *p; GetX509Attr(self, attr); @@ -100,7 +100,9 @@ ossl_x509attr_initialize(int argc, VALUE *argv, VALUE self) oid = ossl_to_der_if_possible(oid); StringValue(oid); p = (unsigned char *)RSTRING_PTR(oid); - if(!d2i_X509_ATTRIBUTE(&attr, &p, RSTRING_LEN(oid)) && (DATA_PTR(self) = attr, 1)){ + x = d2i_X509_ATTRIBUTE(&attr, &p, RSTRING_LEN(oid)); + DATA_PTR(self) = attr; + if(!x){ ossl_raise(eX509AttrError, NULL); } return self; diff --git a/ext/openssl/ossl_x509name.c b/ext/openssl/ossl_x509name.c index 58e2487485..fd8e329a85 100644 --- a/ext/openssl/ossl_x509name.c +++ b/ext/openssl/ossl_x509name.c @@ -137,13 +137,14 @@ ossl_x509name_initialize(int argc, VALUE *argv, VALUE self) else{ const unsigned char *p; VALUE str = ossl_to_der_if_possible(arg); - X509_NAME *x = DATA_PTR(self); + X509_NAME *x; StringValue(str); p = (unsigned char *)RSTRING_PTR(str); - if(!d2i_X509_NAME(&x, &p, RSTRING_LEN(str)) && (DATA_PTR(self) = x, 1)){ + x = d2i_X509_NAME(&name, &p, RSTRING_LEN(str)); + DATA_PTR(self) = name; + if(!x){ ossl_raise(eX509NameError, NULL); } - DATA_PTR(self) = x; } } |