summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog9
-rw-r--r--common.mk1
-rw-r--r--hash.c3
-rw-r--r--symbol.c6
-rw-r--r--symbol.h1
-rw-r--r--version.h6
6 files changed, 22 insertions, 4 deletions
diff --git a/ChangeLog b/ChangeLog
index 4315ce6e3c..07e34f4cd7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+Sun Aug 16 03:00:44 2015 Eric Wong <e@80x24.org>
+
+ * symbol.h (struct RSymbol): add hashval field
+ * symbol.c (dsymbol_alloc): setup hashval field once
+ * hash.c (rb_any_hash): return RSymbol->hashval directly
+ * common.mk: hash.o depends on symbol.h
+ Thanks to Bruno Escherl <bruno@escherl.net> for the bug report
+ [ruby-core:70129] [Bug #11396]
+
Fri Aug 14 16:30:43 2015 Nobuyoshi Nakada <nobu@ruby-lang.org>
* transcode.c (rb_econv_set_replacement): target encoding name can
diff --git a/common.mk b/common.mk
index 1e0120aebe..c3c2b1fad0 100644
--- a/common.mk
+++ b/common.mk
@@ -1450,6 +1450,7 @@ hash.$(OBJEXT): {$(VPATH)}oniguruma.h
hash.$(OBJEXT): {$(VPATH)}probes.h
hash.$(OBJEXT): {$(VPATH)}st.h
hash.$(OBJEXT): {$(VPATH)}subst.h
+hash.$(OBJEXT): {$(VPATH)}symbol.h
hash.$(OBJEXT): {$(VPATH)}util.h
hash.$(OBJEXT): {$(VPATH)}vm_opts.h
inits.$(OBJEXT): $(hdrdir)/ruby/ruby.h
diff --git a/hash.c b/hash.c
index 9a68bd7507..d7a4046a90 100644
--- a/hash.c
+++ b/hash.c
@@ -17,6 +17,7 @@
#include <errno.h>
#include "probes.h"
#include "id.h"
+#include "symbol.h"
#ifdef __APPLE__
# ifdef HAVE_CRT_EXTERNS_H
@@ -150,7 +151,7 @@ rb_any_hash(VALUE a)
hnum = rb_str_hash(a);
}
else if (BUILTIN_TYPE(a) == T_SYMBOL) {
- hnum = rb_objid_hash((st_index_t)a);
+ return RSYMBOL(a)->hashval;
}
else if (BUILTIN_TYPE(a) == T_FLOAT) {
flt:
diff --git a/symbol.c b/symbol.c
index 696f0177b9..903fb5b4c9 100644
--- a/symbol.c
+++ b/symbol.c
@@ -506,12 +506,18 @@ static VALUE
dsymbol_alloc(const VALUE klass, const VALUE str, rb_encoding * const enc, const ID type)
{
const VALUE dsym = rb_newobj_of(klass, T_SYMBOL | FL_WB_PROTECTED);
+ st_index_t hashval;
rb_enc_associate(dsym, enc);
OBJ_FREEZE(dsym);
RB_OBJ_WRITE(dsym, &RSYMBOL(dsym)->fstr, str);
RSYMBOL(dsym)->id = type;
+ /* we want hashval to be in Fixnum range [ruby-core:15713] r15672 */
+ hashval = rb_str_hash(str);
+ hashval <<= 1;
+ RSYMBOL(dsym)->hashval = (st_index_t)RSHIFT(hashval, 1);
+
register_sym(str, dsym);
rb_hash_aset(global_symbols.dsymbol_fstr_hash, str, Qtrue);
diff --git a/symbol.h b/symbol.h
index 549eabdf61..5c52b9742b 100644
--- a/symbol.h
+++ b/symbol.h
@@ -25,6 +25,7 @@
struct RSymbol {
struct RBasic basic;
+ st_index_t hashval;
VALUE fstr;
ID id;
};
diff --git a/version.h b/version.h
index 2888df4699..0c426b02c7 100644
--- a/version.h
+++ b/version.h
@@ -1,10 +1,10 @@
#define RUBY_VERSION "2.2.3"
-#define RUBY_RELEASE_DATE "2015-08-14"
-#define RUBY_PATCHLEVEL 167
+#define RUBY_RELEASE_DATE "2015-08-16"
+#define RUBY_PATCHLEVEL 168
#define RUBY_RELEASE_YEAR 2015
#define RUBY_RELEASE_MONTH 8
-#define RUBY_RELEASE_DAY 14
+#define RUBY_RELEASE_DAY 16
#include "ruby/version.h"