diff options
| -rw-r--r-- | ChangeLog | 13 | ||||
| -rw-r--r-- | dir.c | 10 | ||||
| -rw-r--r-- | error.c | 48 | ||||
| -rw-r--r-- | file.c | 105 | ||||
| -rw-r--r-- | include/ruby/ruby.h | 5 | ||||
| -rw-r--r-- | io.c | 6 | ||||
| -rw-r--r-- | test/ruby/test_literal.rb | 1 | ||||
| -rw-r--r-- | version.h | 2 |
8 files changed, 124 insertions, 66 deletions
@@ -1,3 +1,16 @@ +Sat Feb 25 21:29:09 2012 URABE Shyouhei <shyouhei@ruby-lang.org> + + * test/ruby/test_literal.rb (TestRubyLiteral#test_special_const): + test for https://bugs.php.net/bug.php?id=61095 + +Sat Feb 25 21:29:09 2012 Nobuyoshi Nakada <nobu@ruby-lang.org> + + * dir.c, file.c, io.c (rb_sys_fail_path): use rb_sys_fail_str. + + * error.c: new functions to deal exceptions with string instances. + + * dir.c, file.c, io.c: use rb_sys_fail_path. + Sat Feb 25 21:18:12 2012 Nobuyoshi Nakada <nobu@ruby-lang.org> * dir.c (dir_inspect), io.c (rb_io_inspect): keep encoding of path. @@ -80,6 +80,8 @@ char *strchr(char*,char); #define opendir(p) rb_w32_uopendir(p) #endif +#define rb_sys_fail_path(path) rb_sys_fail_str(path) + #define FNM_NOESCAPE 0x01 #define FNM_PATHNAME 0x02 #define FNM_DOTMATCH 0x04 @@ -762,7 +764,7 @@ dir_chdir(VALUE path) { path = rb_str_encode_ospath(path); if (chdir(RSTRING_PTR(path)) < 0) - rb_sys_fail(RSTRING_PTR(path)); + rb_sys_fail_path(path); } static int chdir_blocking = 0; @@ -934,7 +936,7 @@ dir_s_chroot(VALUE dir, VALUE path) path = rb_str_encode_ospath(path); if (chroot(RSTRING_PTR(path)) == -1) - rb_sys_fail(RSTRING_PTR(path)); + rb_sys_fail_path(path); return INT2FIX(0); } @@ -973,7 +975,7 @@ dir_s_mkdir(int argc, VALUE *argv, VALUE obj) check_dirname(&path); path = rb_str_encode_ospath(path); if (mkdir(RSTRING_PTR(path), mode) == -1) - rb_sys_fail(RSTRING_PTR(path)); + rb_sys_fail_path(path); return INT2FIX(0); } @@ -993,7 +995,7 @@ dir_s_rmdir(VALUE obj, VALUE dir) check_dirname(&dir); dir = rb_str_encode_ospath(dir); if (rmdir(RSTRING_PTR(dir)) < 0) - rb_sys_fail(RSTRING_PTR(dir)); + rb_sys_fail_path(dir); return INT2FIX(0); } @@ -1633,11 +1633,31 @@ make_errno_exc(const char *mesg) return rb_syserr_new(n, mesg); } +static VALUE +make_errno_exc_str(VALUE mesg) +{ + int n = errno; + + errno = 0; + if (!mesg) mesg = Qnil; + if (n == 0) { + const char *s = !NIL_P(mesg) ? RSTRING_PTR(mesg) : ""; + rb_bug("rb_sys_fail_str(%s) - errno == 0", s); + } + return rb_syserr_new_str(n, mesg); +} + VALUE rb_syserr_new(int n, const char *mesg) { VALUE arg; arg = mesg ? rb_str_new2(mesg) : Qnil; + return rb_syserr_new_str(n, arg); +} + +VALUE +rb_syserr_new_str(int n, VALUE arg) +{ return rb_class_new_instance(1, &arg, get_syserr(n)); } @@ -1648,12 +1668,24 @@ rb_syserr_fail(int e, const char *mesg) } void +rb_syserr_fail_str(int e, VALUE mesg) +{ + rb_exc_raise(rb_syserr_new_str(e, mesg)); +} + +void rb_sys_fail(const char *mesg) { rb_exc_raise(make_errno_exc(mesg)); } void +rb_sys_fail_str(VALUE mesg) +{ + rb_exc_raise(make_errno_exc_str(mesg)); +} + +void rb_mod_sys_fail(VALUE mod, const char *mesg) { VALUE exc = make_errno_exc(mesg); @@ -1662,6 +1694,14 @@ rb_mod_sys_fail(VALUE mod, const char *mesg) } void +rb_mod_sys_fail_str(VALUE mod, VALUE mesg) +{ + VALUE exc = make_errno_exc_str(mesg); + rb_extend_object(exc, mod); + rb_exc_raise(exc); +} + +void rb_mod_syserr_fail(VALUE mod, int e, const char *mesg) { VALUE exc = rb_syserr_new(e, mesg); @@ -1670,6 +1710,14 @@ rb_mod_syserr_fail(VALUE mod, int e, const char *mesg) } void +rb_mod_syserr_fail_str(VALUE mod, int e, VALUE mesg) +{ + VALUE exc = rb_syserr_new_str(e, mesg); + rb_extend_object(exc, mod); + rb_exc_raise(exc); +} + +void rb_sys_warning(const char *fmt, ...) { char buf[BUFSIZ]; @@ -94,6 +94,8 @@ int flock(int, int); #define STAT(p, s) stat((p), (s)) #endif +#define rb_sys_fail_path(path) rb_sys_fail_str(path) + #if defined(__BEOS__) || defined(__HAIKU__) /* should not change ID if -1 */ static int be_chown(const char *path, uid_t owner, gid_t group) @@ -207,16 +209,18 @@ rb_str_encode_ospath(VALUE path) } static long -apply2files(void (*func)(const char *, void *), VALUE vargs, void *arg) +apply2files(void (*func)(const char *, VALUE, void *), VALUE vargs, void *arg) { long i; volatile VALUE path; rb_secure(4); for (i=0; i<RARRAY_LEN(vargs); i++) { + const char *s; path = rb_get_path(RARRAY_PTR(vargs)[i]); path = rb_str_encode_ospath(path); - (*func)(StringValueCStr(path), arg); + s = RSTRING_PTR(path); + (*func)(s, path, arg); } return RARRAY_LEN(vargs); @@ -877,7 +881,7 @@ rb_file_s_stat(VALUE klass, VALUE fname) rb_secure(4); FilePathValue(fname); if (rb_stat(fname, &st) < 0) { - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } return stat_new(&st); } @@ -903,7 +907,6 @@ rb_io_stat(VALUE obj) rb_io_t *fptr; struct stat st; -#define rb_sys_fail_path(path) rb_sys_fail(NIL_P(path) ? 0 : RSTRING_PTR(path)) GetOpenFile(obj, fptr); if (fstat(fptr->fd, &st) == -1) { rb_sys_fail_path(fptr->pathv); @@ -935,7 +938,7 @@ rb_file_s_lstat(VALUE klass, VALUE fname) FilePathValue(fname); fname = rb_str_encode_ospath(fname); if (lstat(StringValueCStr(fname), &st) == -1) { - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } return stat_new(&st); #else @@ -1704,7 +1707,7 @@ rb_file_s_size(VALUE klass, VALUE fname) if (rb_stat(fname, &st) < 0) { FilePathValue(fname); - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } return OFFT2NUM(st.st_size); } @@ -1774,7 +1777,7 @@ rb_file_s_ftype(VALUE klass, VALUE fname) FilePathValue(fname); fname = rb_str_encode_ospath(fname); if (lstat(StringValueCStr(fname), &st) == -1) { - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } return rb_file_ftype(&st); @@ -1797,7 +1800,7 @@ rb_file_s_atime(VALUE klass, VALUE fname) if (rb_stat(fname, &st) < 0) { FilePathValue(fname); - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } return stat_atime(&st); } @@ -1843,7 +1846,7 @@ rb_file_s_mtime(VALUE klass, VALUE fname) if (rb_stat(fname, &st) < 0) { FilePathValue(fname); - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } return stat_mtime(&st); } @@ -1892,7 +1895,7 @@ rb_file_s_ctime(VALUE klass, VALUE fname) if (rb_stat(fname, &st) < 0) { FilePathValue(fname); - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } return stat_ctime(&st); } @@ -1950,10 +1953,10 @@ rb_file_size(VALUE obj) } static void -chmod_internal(const char *path, void *mode) +chmod_internal(const char *path, VALUE pathv, void *mode) { if (chmod(path, *(int *)mode) < 0) - rb_sys_fail(path); + rb_sys_fail_path(pathv); } /* @@ -2026,10 +2029,10 @@ rb_file_chmod(VALUE obj, VALUE vmode) #if defined(HAVE_LCHMOD) static void -lchmod_internal(const char *path, void *mode) +lchmod_internal(const char *path, VALUE pathv, void *mode) { if (lchmod(path, (int)(VALUE)mode) < 0) - rb_sys_fail(path); + rb_sys_fail_path(pathv); } /* @@ -2066,11 +2069,11 @@ struct chown_args { }; static void -chown_internal(const char *path, void *arg) +chown_internal(const char *path, VALUE pathv, void *arg) { struct chown_args *args = arg; if (chown(path, args->owner, args->group) < 0) - rb_sys_fail(path); + rb_sys_fail_path(pathv); } /* @@ -2157,11 +2160,11 @@ rb_file_chown(VALUE obj, VALUE owner, VALUE group) #if defined(HAVE_LCHOWN) static void -lchown_internal(const char *path, void *arg) +lchown_internal(const char *path, VALUE pathv, void *arg) { struct chown_args *args = arg; if (lchown(path, args->owner, args->group) < 0) - rb_sys_fail(path); + rb_sys_fail_path(pathv); } /* @@ -2210,10 +2213,10 @@ struct utime_args { }; #if defined DOSISH || defined __CYGWIN__ -NORETURN(static void utime_failed(const char *, const struct timespec *, VALUE, VALUE)); +NORETURN(static void utime_failed(VALUE, const struct timespec *, VALUE, VALUE)); static void -utime_failed(const char *path, const struct timespec *tsp, VALUE atime, VALUE mtime) +utime_failed(VALUE path, const struct timespec *tsp, VALUE atime, VALUE mtime) { if (tsp && errno == EINVAL) { VALUE e[2], a = Qnil, m = Qnil; @@ -2234,23 +2237,23 @@ utime_failed(const char *path, const struct timespec *tsp, VALUE atime, VALUE mt if (!NIL_P(e[0])) { if (path) { if (!d) e[0] = rb_str_dup(e[0]); - rb_str_cat2(rb_str_cat2(e[0], " for "), path); + rb_str_append(rb_str_cat2(e[0], " for "), path); } e[1] = INT2FIX(EINVAL); rb_exc_raise(rb_class_new_instance(2, e, rb_eSystemCallError)); } errno = EINVAL; } - rb_sys_fail(path); + rb_sys_fail_path(path); } #else -#define utime_failed(path, tsp, atime, mtime) rb_sys_fail(path) +#define utime_failed(path, tsp, atime, mtime) rb_sys_fail_path(path) #endif #if defined(HAVE_UTIMES) static void -utime_internal(const char *path, void *arg) +utime_internal(const char *path, VALUE pathv, void *arg) { struct utime_args *v = arg; const struct timespec *tsp = v->tsp; @@ -2280,7 +2283,7 @@ no_utimensat: tvp = tvbuf; } if (utimes(path, tvp) < 0) - utime_failed(path, tsp, v->atime, v->mtime); + utime_failed(pathv, tsp, v->atime, v->mtime); } #else @@ -2293,7 +2296,7 @@ struct utimbuf { #endif static void -utime_internal(const char *path, void *arg) +utime_internal(const char *path, VALUE pathv, void *arg) { struct utime_args *v = arg; const struct timespec *tsp = v->tsp; @@ -2304,7 +2307,7 @@ utime_internal(const char *path, void *arg) utp = &utbuf; } if (utime(path, utp) < 0) - utime_failed(path, tsp, v->atime, v->mtime); + utime_failed(pathv, tsp, v->atime, v->mtime); } #endif @@ -2344,33 +2347,19 @@ NORETURN(static void sys_fail2(VALUE,VALUE)); static void sys_fail2(VALUE s1, VALUE s2) { - char *buf; + VALUE str; #ifdef MAX_PATH const int max_pathlen = MAX_PATH; #else const int max_pathlen = MAXPATHLEN; #endif - const char *e1, *e2; - int len = 5; - long l1 = RSTRING_LEN(s1), l2 = RSTRING_LEN(s2); - e1 = e2 = ""; - if (l1 > max_pathlen) { - l1 = max_pathlen - 3; - e1 = "..."; - len += 3; - } - if (l2 > max_pathlen) { - l2 = max_pathlen - 3; - e2 = "..."; - len += 3; - } - len += (int)l1 + (int)l2; - buf = ALLOCA_N(char, len); - snprintf(buf, len, "(%.*s%s, %.*s%s)", - (int)l1, RSTRING_PTR(s1), e1, - (int)l2, RSTRING_PTR(s2), e2); - rb_sys_fail(buf); + str = rb_str_new_cstr("("); + rb_str_append(str, rb_str_ellipsize(s1, max_pathlen)); + rb_str_cat2(str, ", "); + rb_str_append(str, rb_str_ellipsize(s2, max_pathlen)); + rb_str_cat2(str, ")"); + rb_sys_fail_path(str); } #ifdef HAVE_LINK @@ -2481,10 +2470,10 @@ rb_file_s_readlink(VALUE klass, VALUE path) #endif static void -unlink_internal(const char *path, void *arg) +unlink_internal(const char *path, VALUE pathv, void *arg) { if (unlink(path) < 0) - rb_sys_fail(path); + rb_sys_fail_path(pathv); } /* @@ -3294,7 +3283,7 @@ realpath_rec(long *prefixlenp, VALUE *resolvedp, char *unresolved, VALUE loopche if (!NIL_P(checkval)) { if (checkval == ID2SYM(resolving)) { errno = ELOOP; - rb_sys_fail(RSTRING_PTR(testpath)); + rb_sys_fail_path(testpath); } else { *resolvedp = rb_str_dup(checkval); @@ -3308,12 +3297,12 @@ realpath_rec(long *prefixlenp, VALUE *resolvedp, char *unresolved, VALUE loopche if (ret == -1) { if (errno == ENOENT) { if (strict || !last || *unresolved_firstsep) - rb_sys_fail(RSTRING_PTR(testpath)); + rb_sys_fail_path(testpath); *resolvedp = testpath; break; } else { - rb_sys_fail(RSTRING_PTR(testpath)); + rb_sys_fail_path(testpath); } } #ifdef HAVE_READLINK @@ -3907,18 +3896,18 @@ rb_file_s_truncate(VALUE klass, VALUE path, VALUE len) path = rb_str_encode_ospath(path); #ifdef HAVE_TRUNCATE if (truncate(StringValueCStr(path), pos) < 0) - rb_sys_fail(RSTRING_PTR(path)); + rb_sys_fail_path(path); #else /* defined(HAVE_CHSIZE) */ { int tmpfd; if ((tmpfd = open(StringValueCStr(path), 0)) < 0) { - rb_sys_fail(RSTRING_PTR(path)); + rb_sys_fail_path(path); } rb_update_max_fd(tmpfd); if (chsize(tmpfd, pos) < 0) { close(tmpfd); - rb_sys_fail(RSTRING_PTR(path)); + rb_sys_fail_path(path); } close(tmpfd); } @@ -4257,7 +4246,7 @@ rb_f_test(int argc, VALUE *argv) CHECK(1); if (rb_stat(fname, &st) == -1) { FilePathValue(fname); - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } switch (cmd) { @@ -4346,7 +4335,7 @@ rb_stat_init(VALUE obj, VALUE fname) FilePathValue(fname); fname = rb_str_encode_ospath(fname); if (STAT(StringValueCStr(fname), &st) == -1) { - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } if (DATA_PTR(obj)) { xfree(DATA_PTR(obj)); diff --git a/include/ruby/ruby.h b/include/ruby/ruby.h index fc17f76547..2f97b33bc4 100644 --- a/include/ruby/ruby.h +++ b/include/ruby/ruby.h @@ -1173,13 +1173,18 @@ PRINTF_ARGS(NORETURN(void rb_fatal(const char*, ...)), 1, 2); PRINTF_ARGS(NORETURN(void rb_bug(const char*, ...)), 1, 2); NORETURN(void rb_bug_errno(const char*, int)); NORETURN(void rb_sys_fail(const char*)); +NORETURN(void rb_sys_fail_str(VALUE)); NORETURN(void rb_mod_sys_fail(VALUE, const char*)); +NORETURN(void rb_mod_sys_fail_str(VALUE, VALUE)); NORETURN(void rb_iter_break(void)); NORETURN(void rb_exit(int)); NORETURN(void rb_notimplement(void)); VALUE rb_syserr_new(int, const char *); +VALUE rb_syserr_new_str(int n, VALUE arg); NORETURN(void rb_syserr_fail(int, const char*)); +NORETURN(void rb_syserr_fail_str(int, VALUE)); NORETURN(void rb_mod_syserr_fail(VALUE, int, const char*)); +NORETURN(void rb_mod_syserr_fail_str(VALUE, int, VALUE)); /* reports if `-W' specified */ PRINTF_ARGS(void rb_warning(const char*, ...), 1, 2); @@ -219,7 +219,7 @@ rb_update_max_fd(int fd) # endif #endif -#define rb_sys_fail_path(path) rb_sys_fail(NIL_P(path) ? 0 : RSTRING_PTR(path)) +#define rb_sys_fail_path(path) rb_sys_fail_str(path) static int io_fflush(rb_io_t *); @@ -4795,7 +4795,7 @@ rb_sysopen(VALUE fname, int oflags, mode_t perm) fd = rb_sysopen_internal(&data); } if (fd < 0) { - rb_sys_fail(RSTRING_PTR(fname)); + rb_sys_fail_path(fname); } } rb_update_max_fd(fd); @@ -5407,7 +5407,7 @@ pipe_open(struct rb_exec_arg *eargp, VALUE prog, const char *modestr, int fmode, fp = popen(cmd, modestr); if (eargp) rb_run_exec_options(&sarg, NULL); - if (!fp) rb_sys_fail(RSTRING_PTR(prog)); + if (!fp) rb_sys_fail_path(prog); fd = fileno(fp); #endif diff --git a/test/ruby/test_literal.rb b/test/ruby/test_literal.rb index 85490d659b..bb3f50d2e5 100644 --- a/test/ruby/test_literal.rb +++ b/test/ruby/test_literal.rb @@ -27,6 +27,7 @@ class TestRubyLiteral < Test::Unit::TestCase assert_equal '123456789012345678901234567890', 123456789012345678901234567890.inspect assert_instance_of Bignum, 123456789012345678901234567890 assert_instance_of Float, 1.3 + assert_equal '2', eval("0x00+2").inspect end def test_self @@ -1,5 +1,5 @@ #define RUBY_VERSION "1.9.3" -#define RUBY_PATCHLEVEL 147 +#define RUBY_PATCHLEVEL 148 #define RUBY_RELEASE_DATE "2012-02-25" #define RUBY_RELEASE_YEAR 2012 |