diff options
| -rw-r--r-- | ChangeLog | 5 | ||||
| -rw-r--r-- | ext/openssl/ossl.c | 6 |
2 files changed, 8 insertions, 3 deletions
@@ -1,3 +1,8 @@ +Tue Dec 14 14:03:57 2004 GOTOU Yuuzou <gotoyuzo@notwork.org> + + * ext/openssl/ossl.c (ossl_raise): avoid buffer overrun. + [ruby-dev:25187] + Mon Dec 13 18:13:52 2004 Tanaka Akira <akr@m17n.org> * gc.c (stack_end_address): new function to obtain stack end address. diff --git a/ext/openssl/ossl.c b/ext/openssl/ossl.c index 36a7aa5042..133b4e30ca 100644 --- a/ext/openssl/ossl.c +++ b/ext/openssl/ossl.c @@ -285,17 +285,17 @@ ossl_raise(VALUE exc, const char *fmt, ...) va_start(args, fmt); len = vsnprintf(buf, BUFSIZ, fmt, args); va_end(args); - len += snprintf(buf+len, BUFSIZ-len, ": "); } - if (e) { + if (len < BUFSIZ && e) { if (dOSSL == Qtrue) /* FULL INFO */ msg = ERR_error_string(e, NULL); else msg = ERR_reason_error_string(e); ERR_clear_error(); - len += snprintf(buf+len, BUFSIZ-len, "%s", msg); + len += snprintf(buf+len, BUFSIZ-len, ": %s", msg); } + if(len > BUFSIZ) len = strlen(buf); rb_exc_raise(rb_exc_new(exc, buf, len)); } |