summaryrefslogtreecommitdiff
path: root/tool/lib/output.rb
diff options
context:
space:
mode:
authorKJ Tsanaktsidis <kj@kjtsanaktsidis.id.au>2024-06-02 10:33:46 +1000
committergit <svn-admin@ruby-lang.org>2024-06-05 00:45:53 +0000
commit63e9eaa5bef3fdb1f621d81eab6578fd4cb0f78d (patch)
treea6a6e1f070096e9ce9832dc6a9f356a497445327 /tool/lib/output.rb
parent2e5e47184c59641ab23c6dab74b75404edcbf7f2 (diff)
[ruby/openssl] Fix test_create_with_mac_iter accidently setting keytype not maciterHEADmaster
This test was accidentally passing the value 2048 into the keytype parameter of PKCS12_create, not the mac_iter parameter (because it had one too many `nil`s in the call). This value is invalid, and will make OpenSSL perform an out-of-bounds read which is caught when compiling with ASAN. This commit fixes the tests, and also adds some validation to PKCS12.create to make sure any keytype passed is actually valid. Since there only two valid keytype constants, and the whole feature is an export-grade crypto era thing only ever supported by old MSIE, it seems far more likely that code in the whild is using keytype similarly by mistake rather than as intended. So this validation might catch that. https://github.com/ruby/openssl/commit/47028686d2
Diffstat (limited to 'tool/lib/output.rb')
0 files changed, 0 insertions, 0 deletions