summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authornormal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-07-08 07:27:29 +0000
committernormal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2018-07-08 07:27:29 +0000
commitd41baaee9f4cb725f82d74fc4978d923e6e63cbf (patch)
tree8d6d9787675eda257a481afbec8b9b3bdaf598c7 /test
parentc93adfc170079a54965e939a5a4d57139cd714e1 (diff)
test/ruby (*no_hidden_garbage): disable GC and skip if multi-threaded
Any single object allocation can reduce object count, and object counts are global, so multi-threading leads to unpredictable results. See also similar commits: r60699 and r62608 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'test')
-rw-r--r--test/ruby/test_sprintf.rb5
-rw-r--r--test/ruby/test_time.rb3
2 files changed, 8 insertions, 0 deletions
diff --git a/test/ruby/test_sprintf.rb b/test/ruby/test_sprintf.rb
index a07ac7908b..163d37256c 100644
--- a/test/ruby/test_sprintf.rb
+++ b/test/ruby/test_sprintf.rb
@@ -524,12 +524,17 @@ class TestSprintf < Test::Unit::TestCase
end
def test_no_hidden_garbage
+ skip unless Thread.list.size == 1
+
fmt = [4, 2, 2].map { |x| "%0#{x}d" }.join('-') # defeats optimization
ObjectSpace.count_objects(res = {}) # creates strings on first call
+ GC.disable
before = ObjectSpace.count_objects(res)[:T_STRING]
val = sprintf(fmt, 1970, 1, 1)
after = ObjectSpace.count_objects(res)[:T_STRING]
assert_equal before + 1, after, 'only new string is the created one'
assert_equal '1970-01-01', val
+ ensure
+ GC.enable
end
end
diff --git a/test/ruby/test_time.rb b/test/ruby/test_time.rb
index d89a093303..50ac569c4e 100644
--- a/test/ruby/test_time.rb
+++ b/test/ruby/test_time.rb
@@ -1109,11 +1109,14 @@ class TestTime < Test::Unit::TestCase
fmt = %w(Y m d).map { |x| "%#{x}" }.join('-') # defeats optimization
t = Time.at(0).getutc
ObjectSpace.count_objects(res = {}) # creates strings on first call
+ GC.disable
before = ObjectSpace.count_objects(res)[:T_STRING]
val = t.strftime(fmt)
after = ObjectSpace.count_objects(res)[:T_STRING]
assert_equal before + 1, after, 'only new string is the created one'
assert_equal '1970-01-01', val
+ ensure
+ GC.enable
end
def test_num_exact_error