diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-12-21 19:55:20 +0100 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-05-08 14:13:29 +0900 |
commit | 6438c5848d1f663ecd135903a2a323d6d6006838 (patch) | |
tree | 63f232a115d53170aa81c5af57d69344a693c5ea /test | |
parent | 373d01bb7d136ba514ca5c65298b0196f39d0569 (diff) |
[rubygems/rubygems] Remove misleading comments
`site_dir`, or `vendor_dir`, is the location where the default version
of bundler & rubygems gets installed. These folders are placed directly
in the LOAD_PATH, so they cannot hold any nested gem directory
structure. So a single copy of either rubygems or bundler can be placed
in these folders.
What the tests are actually testing is the TODO comment that I'm
removing: that installing the default copy of bundler doesn't affect any
already installed copies of bundler as regular gems.
https://github.com/rubygems/rubygems/commit/7ca8831d72
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3092
Diffstat (limited to 'test')
-rw-r--r-- | test/rubygems/test_gem_commands_setup_command.rb | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/test/rubygems/test_gem_commands_setup_command.rb b/test/rubygems/test_gem_commands_setup_command.rb index f7d738a816..7d33c0c6d7 100644 --- a/test/rubygems/test_gem_commands_setup_command.rb +++ b/test/rubygems/test_gem_commands_setup_command.rb @@ -254,15 +254,8 @@ class TestGemCommandsSetupCommand < Gem::TestCase # expect to remove normal gem that was same version. because it's promoted default gems. refute_path_exists File.join(Gem.default_dir, "specifications", "bundler-#{BUNDLER_VERS}.gemspec") - # expect to install default gems. It location was `site_ruby` directory on real world. assert_path_exists "default/gems/bundler-#{BUNDLER_VERS}" - - # expect to not remove other versions of bundler on `site_ruby` assert_path_exists 'default/gems/bundler-1.15.4' - - # TODO: We need to assert to remove same version of bundler on gem_dir directory(It's not site_ruby dir) - - # expect to not remove bundler-* directory. assert_path_exists 'default/gems/bundler-audit-1.0.0' end |