summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorAlan Wu <XrXr@users.noreply.github.com>2023-02-24 17:22:48 -0500
committerMaxime Chevalier-Boisvert <maximechevalierb@gmail.com>2023-02-27 11:12:22 -0500
commit0eb634ae73cb327ede833b72492f912792a4a9d5 (patch)
tree93219514a0e566fa3040d5893558d5ac7e60ada4 /test
parent55a24f9b08ac2217accb720e29232d56aed2e5a4 (diff)
YJIT: Detect and reject `send(:alias_for_send, :foo)`
Previously, YJIT failed to put the stack into the correct shape when `BasicObject#send` calls an alias method for the send method itself. This can manifest as strange `NoMethodError`s in the final non-send receiver, as [seen][1] with the kt-paperclip gem. I also found a case where it makes YJIT fail the stack size assertion while compiling `leave`. YJIT's `BasicObject#__send__` implementation already rejects sends to `send`, but didn't detect sends to aliases of `send`. Adjust the detection and reject these cases. Fixes [Bug #19464] [1]: https://github.com/Shopify/yjit/issues/306
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/7377
Diffstat (limited to 'test')
-rw-r--r--test/ruby/test_yjit.rb20
1 files changed, 20 insertions, 0 deletions
diff --git a/test/ruby/test_yjit.rb b/test/ruby/test_yjit.rb
index 7f0f691320..3f7704116f 100644
--- a/test/ruby/test_yjit.rb
+++ b/test/ruby/test_yjit.rb
@@ -1196,6 +1196,26 @@ class TestYJIT < Test::Unit::TestCase
RUBY
end
+ def test_nested_send
+ #[Bug #19464]
+ assert_compiles(<<~RUBY, result: [:ok, :ok])
+ klass = Class.new do
+ class << self
+ alias_method :my_send, :send
+
+ def bar = :ok
+
+ def foo = bar
+ end
+ end
+
+ with_break = -> { break klass.send(:my_send, :foo) }
+ wo_break = -> { klass.send(:my_send, :foo) }
+
+ [with_break[], wo_break[]]
+ RUBY
+ end
+
private
def code_gc_helpers