diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2022-07-12 12:33:12 +0200 |
---|---|---|
committer | git <svn-admin@ruby-lang.org> | 2022-07-14 15:06:09 +0900 |
commit | 76de7a92b90e216c6645e93a3a034bc2f4257b03 (patch) | |
tree | aa663dc015e51cdab1ef3cfae6f57648b5c11cb5 /regexec.c | |
parent | 9d900620cafc379f527ee04a338f3a7f5daf6962 (diff) |
[rubygems/rubygems] Fix misleading error if compact index cannot be copied
Previously if `~/.bundle/cache/compact_index/rubygems.org.*/version`
were owned by root with read-only access, `bundle install` would fail
with a misleading error message. For example:
```
There was an error while trying to write to `/tmp/bundler-compact-index-20220711-1823-npllre/versions`. It is
likely that you need to grant write permissions for that path.
```
This happened because the EACCESS error was caught by
`SharedHelpers.filesystem_access`, which makes it look like the target
directory is at fault instead of the source.
We can't simply drop this guard because that causes the opposite
problem: the permission error appears to come from the source instead of
the target, since `CompactIndexClient::Cache#lines` also wraps read
access errors.
Instead, bring a minimal implementation of `FileUtils.cp` and nest calls
to `SharedHelpers.filesystem_access` properly.
https://github.com/rubygems/rubygems/commit/320822c070
Co-authored-by: Stan Hu <stanhu@gmail.com>
Diffstat (limited to 'regexec.c')
0 files changed, 0 insertions, 0 deletions