summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTakashi Kokubun <takashi.kokubun@shopify.com>2025-08-29 09:40:15 -0700
committerGitHub <noreply@github.com>2025-08-29 09:40:15 -0700
commitfc4f8c879a362968d87d36d6f93d30ae9abd0a5b (patch)
tree6f113ebeda9f03ecdb9aa8bfeb752140eea68c4a
parent7f4a6afab81c8e33fb4a6bbaceca96b6672dc7aa (diff)
YJIT: Drop yjit-bench CI job (#14394)
-rw-r--r--.github/workflows/yjit-ubuntu.yml13
-rw-r--r--yjit/yjit.mk13
2 files changed, 0 insertions, 26 deletions
diff --git a/.github/workflows/yjit-ubuntu.yml b/.github/workflows/yjit-ubuntu.yml
index 3b3b75faac..c4d1c65844 100644
--- a/.github/workflows/yjit-ubuntu.yml
+++ b/.github/workflows/yjit-ubuntu.yml
@@ -101,18 +101,12 @@ jobs:
- test_task: 'test-bundled-gems'
configure: '--enable-yjit=dev'
- - test_task: 'yjit-bench'
- configure: '--enable-yjit=dev'
- yjit_bench_opts: '--yjit-stats'
- continue-on-test_task: true
-
env:
GITPULLOPTIONS: --no-tags origin ${{ github.ref }}
RUN_OPTS: ${{ matrix.yjit_opts }}
YJIT_BENCH_OPTS: ${{ matrix.yjit_bench_opts }}
SPECOPTS: ${{ matrix.specopts }}
RUBY_DEBUG: ci
- BUNDLE_JOBS: 8 # for yjit-bench
RUST_BACKTRACE: 1
runs-on: ubuntu-22.04
@@ -208,13 +202,6 @@ jobs:
LAUNCHABLE_STDERR: ${{ steps.launchable.outputs.stderr_report_path }}
continue-on-error: ${{ matrix.continue-on-test_task || false }}
- - name: Show ${{ github.event.pull_request.base.ref }} GitHub URL for yjit-bench comparison
- run: echo "https://github.com/${BASE_REPO}/commit/${BASE_SHA}"
- env:
- BASE_REPO: ${{ github.event.pull_request.base.repo.full_name }}
- BASE_SHA: ${{ github.event.pull_request.base.sha }}
- if: ${{ matrix.test_task == 'yjit-bench' && startsWith(github.event_name, 'pull') }}
-
- uses: ./.github/actions/slack
with:
label: ${{ matrix.test_task }} ${{ matrix.configure }}
diff --git a/yjit/yjit.mk b/yjit/yjit.mk
index c6571ecbc8..39587928d4 100644
--- a/yjit/yjit.mk
+++ b/yjit/yjit.mk
@@ -31,19 +31,6 @@ ifneq ($(YJIT_SUPPORT),no)
$(RUST_LIB): $(YJIT_SRC_FILES)
endif
-# By using YJIT_BENCH_OPTS instead of RUN_OPTS, you can skip passing the options to `make install`
-YJIT_BENCH_OPTS = $(RUN_OPTS) --enable-gems
-YJIT_BENCH = benchmarks/railsbench/benchmark.rb
-
-# Run yjit-bench's ./run_once.sh for CI
-yjit-bench: install update-yjit-bench PHONY
- $(Q) cd $(srcdir)/yjit-bench && PATH=$(prefix)/bin:$$PATH \
- ./run_once.sh $(YJIT_BENCH_OPTS) $(YJIT_BENCH)
-
-update-yjit-bench:
- $(Q) $(tooldir)/git-refresh -C $(srcdir) --branch main \
- https://github.com/Shopify/yjit-bench yjit-bench $(GIT_OPTS)
-
RUST_VERSION = +1.58.0
# Gives quick feedback about YJIT. Not a replacement for a full test run.