diff options
| author | Utkarsh Gupta <utkarsh@debian.org> | 2020-06-21 16:46:34 +0530 |
|---|---|---|
| committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-07-15 16:05:12 +0900 |
| commit | ecb87b55d8ef3e2e9b5ce2c66d51d65228316754 (patch) | |
| tree | 1777e9395c92a9463b64c642a7970f15710c2ae5 | |
| parent | 215f7c31658a649efa276e18811d69f111931f0f (diff) | |
[rubygems/rubygems] Lock rubocop version to 0.80.1
The later RuboCop versions don't work with ruby2.3
so we should lock the version to what works with
ruby2.3 as we haven't dropped the support yet.
And since we're using the older version of rubocop,
also fix `Max` value of `LineLength` to 120, which
is the current standard. Without this, rubocop
will throw the line length offenses.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/46d0a800a2
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
| -rw-r--r-- | lib/bundler/templates/newgem/rubocop.yml.tt | 3 | ||||
| -rw-r--r-- | spec/bundler/commands/newgem_spec.rb | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/lib/bundler/templates/newgem/rubocop.yml.tt b/lib/bundler/templates/newgem/rubocop.yml.tt index ca11bac1b6..00a72e3006 100644 --- a/lib/bundler/templates/newgem/rubocop.yml.tt +++ b/lib/bundler/templates/newgem/rubocop.yml.tt @@ -5,3 +5,6 @@ Style/StringLiterals: Style/StringLiteralsInInterpolation: Enabled: true EnforcedStyle: double_quotes + +Layout/LineLength: + Max: 120 diff --git a/spec/bundler/commands/newgem_spec.rb b/spec/bundler/commands/newgem_spec.rb index b1e84c73f3..0287fb6e26 100644 --- a/spec/bundler/commands/newgem_spec.rb +++ b/spec/bundler/commands/newgem_spec.rb @@ -177,7 +177,7 @@ RSpec.describe "bundle gem" do it "run rubocop inside the generated gem with no offenses" do prepare_gemspec(bundled_app(gem_name, "#{gem_name}.gemspec")) - gems = ["rake", "rubocop"] + gems = ["rake", "rubocop -v 0.80.1"] path = Bundler.feature_flag.default_install_uses_path? ? local_gem_path(:base => bundled_app(gem_name)) : system_gem_path realworld_system_gems gems, :path => path bundle "exec rubocop --ignore-parent-exclusion", :dir => bundled_app(gem_name) |