summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorU.Nakamura <usa@ruby-lang.org>2023-10-10 20:02:12 +0900
committerU.Nakamura <usa@ruby-lang.org>2023-10-10 20:02:12 +0900
commiteb54ed809f61fb25a0de101a7a6a649e8d4a434c (patch)
treeac2fd32d0429dfc7de0af679db7f43e1221b3e55
parent4153e807c55ec0fc234969ae08a01c1e0c8ed167 (diff)
merge revision(s) a28c5151f567cada0d2f5c0c3ec4df7f97b80784: [Backport #19855]
Fix Array#bsearch when block returns a non-integer numeric value --- array.c | 4 ++-- test/ruby/test_array.rb | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-)
-rw-r--r--array.c4
-rw-r--r--test/ruby/test_array.rb4
-rw-r--r--version.h6
3 files changed, 9 insertions, 5 deletions
diff --git a/array.c b/array.c
index 8becdbbc91..5824345cc9 100644
--- a/array.c
+++ b/array.c
@@ -3469,8 +3469,8 @@ rb_ary_bsearch_index(VALUE ary)
const VALUE zero = INT2FIX(0);
switch (rb_cmpint(rb_funcallv(v, id_cmp, 1, &zero), v, zero)) {
case 0: return INT2FIX(mid);
- case 1: smaller = 1; break;
- case -1: smaller = 0;
+ case 1: smaller = 0; break;
+ case -1: smaller = 1;
}
}
else {
diff --git a/test/ruby/test_array.rb b/test/ruby/test_array.rb
index ccbe85877f..0ed8ada95c 100644
--- a/test/ruby/test_array.rb
+++ b/test/ruby/test_array.rb
@@ -3218,6 +3218,8 @@ class TestArray < Test::Unit::TestCase
assert_equal(nil, a.bsearch {|x| 1 * (2**100) })
assert_equal(nil, a.bsearch {|x| (-1) * (2**100) })
+ assert_equal(4, a.bsearch {|x| (4 - x).to_r })
+
assert_include([4, 7], a.bsearch {|x| (2**100).coerce((1 - x / 4) * (2**100)).first })
end
@@ -3253,6 +3255,8 @@ class TestArray < Test::Unit::TestCase
assert_equal(nil, a.bsearch_index {|x| 1 * (2**100) })
assert_equal(nil, a.bsearch_index {|x| (-1) * (2**100) })
+ assert_equal(1, a.bsearch_index {|x| (4 - x).to_r })
+
assert_include([1, 2], a.bsearch_index {|x| (2**100).coerce((1 - x / 4) * (2**100)).first })
end
diff --git a/version.h b/version.h
index c6c40fc9dd..052d9bcae7 100644
--- a/version.h
+++ b/version.h
@@ -11,11 +11,11 @@
# define RUBY_VERSION_MINOR RUBY_API_VERSION_MINOR
#define RUBY_VERSION_TEENY 4
#define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR
-#define RUBY_PATCHLEVEL 239
+#define RUBY_PATCHLEVEL 240
#define RUBY_RELEASE_YEAR 2023
-#define RUBY_RELEASE_MONTH 9
-#define RUBY_RELEASE_DAY 19
+#define RUBY_RELEASE_MONTH 10
+#define RUBY_RELEASE_DAY 10
#include "ruby/version.h"