diff options
author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2019-10-17 14:42:38 +0900 |
---|---|---|
committer | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2019-10-17 18:51:51 +0900 |
commit | e169ad93f44e1944ecf7bb65133fd34e8b868ea8 (patch) | |
tree | 82c3badab1865e5036dd054dcb15b7fdc3f7c61e | |
parent | 2a261909cc6d0767d584c0555a1c6594aacf567a (diff) |
Fixed File.extname at a name ending with a dot
File.extname now returns a dot string at a name ending with a dot.
[Bug #15267]
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/2565
-rw-r--r-- | NEWS | 8 | ||||
-rw-r--r-- | file.c | 4 | ||||
-rw-r--r-- | spec/ruby/core/file/extname_spec.rb | 10 | ||||
-rw-r--r-- | test/ruby/test_file_exhaustive.rb | 10 | ||||
-rw-r--r-- | test/ruby/test_path.rb | 8 |
5 files changed, 30 insertions, 10 deletions
@@ -191,6 +191,14 @@ Fiber:: * Added Fiber#raise that behaves like Fiber#resume but raises an exception on the resumed fiber. [Feature #10344] +File:: + Modified method:: + + * File.extname now returns a dot string at a name ending with a + dot. [Bug #15267] + + File.extname("foo.") #=> "." + FrozenError:: New method:: @@ -4792,7 +4792,7 @@ ruby_enc_find_extname(const char *name, long *len, rb_encoding *enc) * File.extname("test.rb") #=> ".rb" * File.extname("a/b/d/test.rb") #=> ".rb" * File.extname(".a/b/d/test.rb") #=> ".rb" - * File.extname("foo.") #=> "" + * File.extname("foo.") #=> "." * File.extname("test") #=> "" * File.extname(".profile") #=> "" * File.extname(".profile.sh") #=> ".sh" @@ -4810,7 +4810,7 @@ rb_file_s_extname(VALUE klass, VALUE fname) name = StringValueCStr(fname); len = RSTRING_LEN(fname); e = ruby_enc_find_extname(name, &len, rb_enc_get(fname)); - if (len <= 1) + if (len < 1) return rb_str_new(0, 0); extname = rb_str_subseq(fname, e - name, len); /* keep the dot, too! */ OBJ_INFECT(extname, fname); diff --git a/spec/ruby/core/file/extname_spec.rb b/spec/ruby/core/file/extname_spec.rb index 358690b44a..3b7fa5a128 100644 --- a/spec/ruby/core/file/extname_spec.rb +++ b/spec/ruby/core/file/extname_spec.rb @@ -20,8 +20,14 @@ describe "File.extname" do File.extname("..").should == "" File.extname("...").should == "" File.extname("....").should == "" - File.extname(".foo.").should == "" - File.extname("foo.").should == "" + guard -> { platform_is :windows or ruby_version_is ""..."2.7" } do + File.extname(".foo.").should == "" + File.extname("foo.").should == "" + end + guard -> { platform_is_not :windows and ruby_version_is "2.7" } do + File.extname(".foo.").should == "." + File.extname("foo.").should == "." + end end it "returns only the last extension of a file with several dots" do diff --git a/test/ruby/test_file_exhaustive.rb b/test/ruby/test_file_exhaustive.rb index 6b80b82389..4bb5479303 100644 --- a/test/ruby/test_file_exhaustive.rb +++ b/test/ruby/test_file_exhaustive.rb @@ -1308,21 +1308,23 @@ class TestFileExhaustive < Test::Unit::TestCase assert_equal(".test", File.extname(regular_file)) assert_equal(".test", File.extname(utf8_file)) prefixes = ["", "/", ".", "/.", "bar/.", "/bar/."] - infixes = ["", " ", "."] + infixes = ["", " "] infixes2 = infixes + [".ext "] appendixes = [""] if NTFS appendixes << " " << "." << "::$DATA" << "::$DATA.bar" + else + appendixes << [".", "."] end prefixes.each do |prefix| - appendixes.each do |appendix| + appendixes.each do |appendix, ext = ""| infixes.each do |infix| path = "#{prefix}foo#{infix}#{appendix}" - assert_equal("", File.extname(path), "File.extname(#{path.inspect})") + assert_equal(ext, File.extname(path), "File.extname(#{path.inspect})") end infixes2.each do |infix| path = "#{prefix}foo#{infix}.ext#{appendix}" - assert_equal(".ext", File.extname(path), "File.extname(#{path.inspect})") + assert_equal(ext.empty? ? ".ext" : appendix, File.extname(path), "File.extname(#{path.inspect})") end end end diff --git a/test/ruby/test_path.rb b/test/ruby/test_path.rb index 6af4fb6ac0..b35e942a2a 100644 --- a/test/ruby/test_path.rb +++ b/test/ruby/test_path.rb @@ -236,10 +236,14 @@ class TestPath < Test::Unit::TestCase assert_equal(ext, File.extname('.a/b/d/test.rb')) unless /mswin|bccwin|mingw/ =~ RUBY_PLATFORM # trailing spaces and dots are ignored on NTFS. - ext = '' + ext = '.' end assert_equal(ext, File.extname('a.rb.')) - assert_equal('', File.extname('a.')) + if /mswin|bccwin|mingw/ =~ RUBY_PLATFORM + # trailing spaces and dots are ignored on NTFS. + ext = '' + end + assert_equal(ext, File.extname('a.')) assert_equal('', File.extname('.x')) assert_equal('', File.extname('..x')) end |