diff options
author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2022-08-20 01:43:04 +0900 |
---|---|---|
committer | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2022-08-20 10:06:16 +0900 |
commit | d2483393cbcb4dcfa0000fa8166bb7fa7ed9f7b4 (patch) | |
tree | 5db32cf5e09b6aaddf4161e37e81d4cd961a71b8 | |
parent | 8f4a53d0517a99e57060211a3efe2d7a9d5d06b2 (diff) |
[Bug #18956] Negative codepoints are invalid characters
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/6259
-rw-r--r-- | sprintf.c | 4 | ||||
-rw-r--r-- | test/ruby/test_sprintf.rb | 1 |
2 files changed, 3 insertions, 2 deletions
@@ -447,8 +447,8 @@ rb_str_format(int argc, const VALUE *argv, VALUE fmt) goto format_s1; } else { - c = NUM2INT(val); - n = rb_enc_codelen(c, enc); + n = NUM2INT(val); + if (n >= 0) n = rb_enc_codelen((c = n), enc); } if (n <= 0) { rb_raise(rb_eArgError, "invalid character"); diff --git a/test/ruby/test_sprintf.rb b/test/ruby/test_sprintf.rb index 618e67264a..803399fdb3 100644 --- a/test/ruby/test_sprintf.rb +++ b/test/ruby/test_sprintf.rb @@ -368,6 +368,7 @@ class TestSprintf < Test::Unit::TestCase assert_equal(" " * (BSIZ - 1) + "a", sprintf(" " * (BSIZ - 1) + "%-1c", ?a)) assert_equal(" " * BSIZ + "a", sprintf("%#{ BSIZ + 1 }c", ?a)) assert_equal("a" + " " * BSIZ, sprintf("%-#{ BSIZ + 1 }c", ?a)) + assert_raise(ArgumentError) { sprintf("%c", -1) } end def test_string |