diff options
author | Koichi Sasada <ko1@atdot.net> | 2020-12-19 04:30:25 +0900 |
---|---|---|
committer | Koichi Sasada <ko1@atdot.net> | 2020-12-19 04:33:04 +0900 |
commit | cee02d754d76563635c1db90d2ab6c01f8492470 (patch) | |
tree | 115c68c2708aabb557243868cb870fe55b811e64 | |
parent | 04d62e6f6202684c57f2fcf71bbfcb891cd4ddd9 (diff) |
fix refinements/prepend bug
replaced method entry should be invalidated.
[Bug #17386]
-rw-r--r-- | class.c | 4 | ||||
-rw-r--r-- | test/ruby/test_refinement.rb | 27 |
2 files changed, 30 insertions, 1 deletions
@@ -1110,7 +1110,9 @@ move_refined_method(ID key, VALUE value, void *data) struct rb_id_table *tbl = RCLASS_M_TBL(klass); if (me->def->type == VM_METHOD_TYPE_REFINED) { - if (me->def->body.refined.orig_me) { + rb_clear_method_cache(klass, me->called_id); + + if (me->def->body.refined.orig_me) { const rb_method_entry_t *orig_me = me->def->body.refined.orig_me, *new_me; RB_OBJ_WRITE(me, &me->def->body.refined.orig_me, NULL); new_me = rb_method_entry_clone(me); diff --git a/test/ruby/test_refinement.rb b/test/ruby/test_refinement.rb index 61ad2d92e7..b27a176889 100644 --- a/test/ruby/test_refinement.rb +++ b/test/ruby/test_refinement.rb @@ -2446,4 +2446,31 @@ class TestRefinement < Test::Unit::TestCase def eval_using(mod, s) eval("using #{mod}; #{s}", Sandbox::BINDING) end + + # [Bug #17386] + def test_prepended_with_method_cache + foo = Class.new do + def foo + :Foo + end + end + + code = Module.new do + def foo + :Code + end + end + + _ext = Module.new do + refine foo do + def foo; end + end + end + + obj = foo.new + + assert_equal :Foo, obj.foo + foo.prepend code + assert_equal :Code, obj.foo + end end |