diff options
| author | Samuel Giddins <segiddins@segiddins.me> | 2023-09-18 14:16:06 -0700 |
|---|---|---|
| committer | git <svn-admin@ruby-lang.org> | 2023-09-19 07:14:53 +0000 |
| commit | cea7e6ecca99ae7730ea5ac44ed15f62b1599664 (patch) | |
| tree | a55149c32451e2d4cd6604b77a9f36ccc6d33f4b | |
| parent | 647390308239fbf82d159ecd83ed8df090af518d (diff) | |
[rubygems/rubygems] Lazily construct fetcher debug messages
Avoids constructing several strings
https://github.com/rubygems/rubygems/commit/8a322dbe11
| -rw-r--r-- | lib/bundler/fetcher/base.rb | 4 | ||||
| -rw-r--r-- | lib/bundler/fetcher/compact_index.rb | 2 | ||||
| -rw-r--r-- | lib/bundler/fetcher/dependency.rb | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/lib/bundler/fetcher/base.rb b/lib/bundler/fetcher/base.rb index 62cc75add8..99c6343c9a 100644 --- a/lib/bundler/fetcher/base.rb +++ b/lib/bundler/fetcher/base.rb @@ -38,9 +38,9 @@ module Bundler private - def log_specs(debug_msg) + def log_specs(&block) if Bundler.ui.debug? - Bundler.ui.debug debug_msg + Bundler.ui.debug yield else Bundler.ui.info ".", false end diff --git a/lib/bundler/fetcher/compact_index.rb b/lib/bundler/fetcher/compact_index.rb index 6786a841f5..dc30443e27 100644 --- a/lib/bundler/fetcher/compact_index.rb +++ b/lib/bundler/fetcher/compact_index.rb @@ -35,7 +35,7 @@ module Bundler remaining_gems = gem_names.dup until remaining_gems.empty? - log_specs "Looking up gems #{remaining_gems.inspect}" + log_specs { "Looking up gems #{remaining_gems.inspect}" } deps = begin parallel_compact_index_client.dependencies(remaining_gems) diff --git a/lib/bundler/fetcher/dependency.rb b/lib/bundler/fetcher/dependency.rb index 18b606abb6..0b807c9a4b 100644 --- a/lib/bundler/fetcher/dependency.rb +++ b/lib/bundler/fetcher/dependency.rb @@ -24,7 +24,7 @@ module Bundler def specs(gem_names, full_dependency_list = [], last_spec_list = []) query_list = gem_names.uniq - full_dependency_list - log_specs "Query List: #{query_list.inspect}" + log_specs { "Query List: #{query_list.inspect}" } return last_spec_list if query_list.empty? |