diff options
| author | Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com> | 2024-02-04 00:36:34 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-04 05:36:34 +0000 |
| commit | ba16b340981942eda82d6328800b8098c452c0ca (patch) | |
| tree | 955c3f5fc5ea55e2930e8bfe5857835bc4e488f9 | |
| parent | ce6863a0cf971e0c0328e3fc85b10b6de36ecbad (diff) | |
YJIT: reduce default exec mem size to 48MiB (#9692)
* YJIT: reduce default exec mem size to 48MiB based
Based on user feedback from @jhawthorn and others.
Better for small and memory-constrained deployments.
NOTE: This commit should be included in the next Ruby 3.3.x point
release. @xrxr should we tag someone specific?
* YJIT: Update yjit.md about mem size (#9687)
---------
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
| -rw-r--r-- | doc/yjit/yjit.md | 6 | ||||
| -rw-r--r-- | yjit/src/options.rs | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/doc/yjit/yjit.md b/doc/yjit/yjit.md index ba6772727f..e6446e3ed1 100644 --- a/doc/yjit/yjit.md +++ b/doc/yjit/yjit.md @@ -165,7 +165,7 @@ The machine code generated for a given method can be printed by adding `puts Rub YJIT supports all command-line options supported by upstream CRuby, but also adds a few YJIT-specific options: - `--yjit`: enable YJIT (disabled by default) -- `--yjit-exec-mem-size=N`: size of the executable memory block to allocate, in MiB (default 64 MiB) +- `--yjit-exec-mem-size=N`: size of the executable memory block to allocate, in MiB (default 48 MiB) - `--yjit-call-threshold=N`: number of calls after which YJIT begins to compile a function. It defaults to 30, and it's then increased to 120 when the number of ISEQs in the process reaches 40,000. - `--yjit-cold-threshold=N`: number of global calls after which an ISEQ is considered cold and not @@ -243,8 +243,8 @@ which often consumes more memory than JIT code. Generally, YJIT adds memory over 3-4x of `--yjit-exec-mem-size` in production as of Ruby 3.3. You should multiply that by the number of worker processes to estimate the worst case memory overhead. -We use `--yjit-exec-mem-size=64` for Shopify's Rails monolith, which is Ruby 3.3's default, -but smaller values like 32 MiB or 48 MiB might make sense for your application. +`--yjit-exec-mem-size=48` is the default since Ruby 3.3.1, +but smaller values like 32 MiB might make sense for your application. While doing so, you may want to monitor `RubyVM::YJIT.runtime_stats[:ratio_in_yjit]` as explained above. ### Enabling YJIT lazily diff --git a/yjit/src/options.rs b/yjit/src/options.rs index 72db513030..5a60bc8f49 100644 --- a/yjit/src/options.rs +++ b/yjit/src/options.rs @@ -81,7 +81,7 @@ pub struct Options { // Initialize the options to default values pub static mut OPTIONS: Options = Options { - exec_mem_size: 64 * 1024 * 1024, + exec_mem_size: 48 * 1024 * 1024, no_type_prop: false, max_versions: 4, num_temp_regs: 5, @@ -101,7 +101,7 @@ pub static mut OPTIONS: Options = Options { /// YJIT option descriptions for `ruby --help`. static YJIT_OPTIONS: [(&str, &str); 9] = [ - ("--yjit-exec-mem-size=num", "Size of executable memory block in MiB (default: 64)"), + ("--yjit-exec-mem-size=num", "Size of executable memory block in MiB (default: 48)"), ("--yjit-call-threshold=num", "Number of calls to trigger JIT"), ("--yjit-cold-threshold=num", "Global calls after which ISEQs not compiled (default: 200K)"), ("--yjit-stats", "Enable collecting YJIT statistics"), |