summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Bernstein <ruby@bernsteinbear.com>2025-11-14 14:39:22 -0500
committerMax Bernstein <tekknolagi@gmail.com>2025-11-14 12:41:05 -0800
commitad6ca3a7aaa6cd1306f1311148eb6673d1e64511 (patch)
tree160a4aaa4a29a4693a7f18e5a3b227320dfbc475
parent4683ce5fecf65ffbbdeb800f9fc58e67d307a216 (diff)
ZJIT: Move special Fixnum BOP_GT into cruby_methods
-rw-r--r--zjit/src/cruby_methods.rs6
-rw-r--r--zjit/src/hir.rs2
-rw-r--r--zjit/src/hir/opt_tests.rs12
3 files changed, 13 insertions, 7 deletions
diff --git a/zjit/src/cruby_methods.rs b/zjit/src/cruby_methods.rs
index 5de7059167..619aa4e491 100644
--- a/zjit/src/cruby_methods.rs
+++ b/zjit/src/cruby_methods.rs
@@ -229,6 +229,7 @@ pub fn init() -> Annotations {
annotate!(rb_cInteger, "==", inline_integer_eq);
annotate!(rb_cInteger, "+", inline_integer_plus);
annotate!(rb_cInteger, "-", inline_integer_minus);
+ annotate!(rb_cInteger, ">", inline_integer_gt);
annotate!(rb_cString, "to_s", inline_string_to_s, types::StringExact);
let thread_singleton = unsafe { rb_singleton_class(rb_cThread) };
annotate!(thread_singleton, "current", types::BasicObject, no_gc, leaf);
@@ -456,6 +457,11 @@ fn inline_integer_minus(fun: &mut hir::Function, block: hir::BlockId, recv: hir:
try_inline_fixnum_op(fun, block, &|left, right| hir::Insn::FixnumSub { left, right, state }, BOP_MINUS, recv, other, state)
}
+fn inline_integer_gt(fun: &mut hir::Function, block: hir::BlockId, recv: hir::InsnId, args: &[hir::InsnId], state: hir::InsnId) -> Option<hir::InsnId> {
+ let &[other] = args else { return None; };
+ try_inline_fixnum_op(fun, block, &|left, right| hir::Insn::FixnumGt { left, right }, BOP_GT, recv, other, state)
+}
+
fn inline_basic_object_eq(fun: &mut hir::Function, block: hir::BlockId, recv: hir::InsnId, args: &[hir::InsnId], _state: hir::InsnId) -> Option<hir::InsnId> {
let &[other] = args else { return None; };
let c_result = fun.push_insn(block, hir::Insn::IsBitEqual { left: recv, right: other });
diff --git a/zjit/src/hir.rs b/zjit/src/hir.rs
index 23beacf84f..f81ab00458 100644
--- a/zjit/src/hir.rs
+++ b/zjit/src/hir.rs
@@ -2331,8 +2331,6 @@ impl Function {
self.try_rewrite_fixnum_op(block, insn_id, &|left, right| Insn::FixnumLt { left, right }, BOP_LT, recv, args[0], state),
Insn::SendWithoutBlock { recv, args, state, cd, .. } if ruby_call_method_id(cd) == ID!(le) && args.len() == 1 =>
self.try_rewrite_fixnum_op(block, insn_id, &|left, right| Insn::FixnumLe { left, right }, BOP_LE, recv, args[0], state),
- Insn::SendWithoutBlock { recv, args, state, cd, .. } if ruby_call_method_id(cd) == ID!(gt) && args.len() == 1 =>
- self.try_rewrite_fixnum_op(block, insn_id, &|left, right| Insn::FixnumGt { left, right }, BOP_GT, recv, args[0], state),
Insn::SendWithoutBlock { recv, args, state, cd, .. } if ruby_call_method_id(cd) == ID!(ge) && args.len() == 1 =>
self.try_rewrite_fixnum_op(block, insn_id, &|left, right| Insn::FixnumGe { left, right }, BOP_GE, recv, args[0], state),
Insn::SendWithoutBlock { recv, args, state, cd, .. } if ruby_call_method_id(cd) == ID!(and) && args.len() == 1 =>
diff --git a/zjit/src/hir/opt_tests.rs b/zjit/src/hir/opt_tests.rs
index e716640d8a..d65e3669ff 100644
--- a/zjit/src/hir/opt_tests.rs
+++ b/zjit/src/hir/opt_tests.rs
@@ -332,8 +332,9 @@ mod hir_opt_tests {
bb2(v6:BasicObject):
v10:Fixnum[2] = Const Value(2)
v12:Fixnum[1] = Const Value(1)
- PatchPoint BOPRedefined(INTEGER_REDEFINED_OP_FLAG, BOP_GT)
- v38:TrueClass = Const Value(true)
+ PatchPoint MethodRedefined(Integer@0x1000, >@0x1008, cme:0x1010)
+ v40:TrueClass = Const Value(true)
+ IncrCounter inline_cfunc_optimized_send_count
CheckInterrupts
v22:Fixnum[3] = Const Value(3)
CheckInterrupts
@@ -1903,9 +1904,10 @@ mod hir_opt_tests {
EntryPoint JIT(0)
Jump bb2(v6, v7, v8)
bb2(v10:BasicObject, v11:BasicObject, v12:BasicObject):
- PatchPoint BOPRedefined(INTEGER_REDEFINED_OP_FLAG, BOP_GT)
- v29:Fixnum = GuardType v11, Fixnum
- v30:Fixnum = GuardType v12, Fixnum
+ PatchPoint MethodRedefined(Integer@0x1000, >@0x1008, cme:0x1010)
+ v30:Fixnum = GuardType v11, Fixnum
+ v31:Fixnum = GuardType v12, Fixnum
+ IncrCounter inline_cfunc_optimized_send_count
v23:Fixnum[5] = Const Value(5)
CheckInterrupts
Return v23