summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJun Aruga <jaruga@redhat.com>2022-05-18 14:24:18 +0200
committerJun Aruga <junaruga@users.noreply.github.com>2022-06-13 12:12:18 +0200
commita80f5c536598157da83f8de8f328d03207801c43 (patch)
tree0b5d31b9276b411b6703e3c8e171e5429b2f0032
parentb2e58b02aec73f9c350bf109c021c180fc699ccc (diff)
Enable "make annocheck" on platforms other than Linux.
The annocheck supports ELF format binaries compiled for any OS and for any architecture. It can work in not only Linux but also FreeBSD and Solaris. It is designed to be independent of the host OS and the architecture. Even in Mac, as the binaries are Mach-O foramt, the annocheck fails correctly with the message. e.g. Test binaries compiled for Mac OSX 10.13.6 (target_os: darwin17) in Fedora 35. ``` $ cat /etc/fedora-release Fedora release 35 (Thirty Five) $ file ruby ruby: Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE> $ annocheck ruby annocheck: Version 10.66. annocheck: Warning: ruby: is not an ELF format file. ``` See <https://sourceware.org/bugzilla/show_bug.cgi?id=29173> for details.
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/5916
-rw-r--r--common.mk7
1 files changed, 4 insertions, 3 deletions
diff --git a/common.mk b/common.mk
index cd190952d9..db4a283602 100644
--- a/common.mk
+++ b/common.mk
@@ -1447,10 +1447,11 @@ yes-test-bundler-parallel: yes-test-bundler-prepare
$(PARALLELRSPECOPTS) $(srcdir)/spec/bundler/$(BUNDLER_SPECS)
no-test-bundler-parallel:
-test-annocheck: $(target_os)-test-annocheck
-linux-test-annocheck: $(PROGRAM)
+# The annocheck supports ELF format binaries compiled for any OS and for any
+# architecture. It is designed to be independent of the host OS and the
+# architecture. The test-annocheck.sh requires docker or podman.
+test-annocheck: $(PROGRAM)
$(tooldir)/test-annocheck.sh $(PROGRAM)
-$(target_os)-test-annocheck: PHONY
GEM = up
sync-default-gems: