diff options
| author | Aaron Patterson <tenderlove@ruby-lang.org> | 2021-06-10 09:40:30 -0700 |
|---|---|---|
| committer | Alan Wu <XrXr@users.noreply.github.com> | 2021-10-20 18:19:36 -0400 |
| commit | 9043ad3d74413823e62b11923652d272e41dc230 (patch) | |
| tree | d11210a1f2cdf3958ee2ea66d2cf32b6db77597c | |
| parent | 986b9b47d11829f1071f7d3bab78f847ea4543bf (diff) | |
Implement topn instruction
This commit implements the topn instruction
Co-Authored-By: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
Co-Authored-By: Noah Gibbs <noah.gibbs@shopify.com>
| -rw-r--r-- | bootstraptest/test_yjit.rb | 18 | ||||
| -rw-r--r-- | yjit_codegen.c | 18 |
2 files changed, 36 insertions, 0 deletions
diff --git a/bootstraptest/test_yjit.rb b/bootstraptest/test_yjit.rb index 51c82b55b5..fcf027d728 100644 --- a/bootstraptest/test_yjit.rb +++ b/bootstraptest/test_yjit.rb @@ -1,3 +1,21 @@ +# Test for topn +assert_equal 'array', %q{ + def threequals(a) + case a + when Array + "array" + when Hash + "hash" + else + "unknown" + end + end + + threequals([]) + threequals([]) + threequals([]) +} + # Test for opt_mod assert_equal '2', %q{ def mod(a, b) diff --git a/yjit_codegen.c b/yjit_codegen.c index dc148c1951..487c1cee98 100644 --- a/yjit_codegen.c +++ b/yjit_codegen.c @@ -583,6 +583,23 @@ gen_setn(jitstate_t* jit, ctx_t* ctx) return YJIT_KEEP_COMPILING; } +// get nth stack value, then push it +static codegen_status_t +gen_topn(jitstate_t* jit, ctx_t* ctx) +{ + int32_t n = (int32_t)jit_get_arg(jit, 0); + + // Get top n type / operand + val_type_t top_n_type = ctx_get_opnd_type(ctx, OPND_STACK(n)); + x86opnd_t top_n_val = ctx_stack_opnd(ctx, n); + + x86opnd_t loc0 = ctx_stack_push(ctx, top_n_type); + mov(cb, REG0, top_n_val); + mov(cb, loc0, REG0); + + return YJIT_KEEP_COMPILING; +} + static codegen_status_t gen_pop(jitstate_t* jit, ctx_t* ctx) { @@ -3191,6 +3208,7 @@ yjit_init_codegen(void) yjit_reg_op(BIN(dup), gen_dup); yjit_reg_op(BIN(dupn), gen_dupn); yjit_reg_op(BIN(setn), gen_setn); + yjit_reg_op(BIN(topn), gen_topn); yjit_reg_op(BIN(pop), gen_pop); yjit_reg_op(BIN(adjuststack), gen_adjuststack); yjit_reg_op(BIN(newarray), gen_newarray); |