diff options
author | Josef Šimánek <josef.simanek@gmail.com> | 2020-05-09 00:23:19 +0200 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-06-05 07:32:42 +0900 |
commit | 464e094fce3267d44c6878fda5481b178df42f94 (patch) | |
tree | fc61fafd510ce8752790a4313d381fc34b51863a | |
parent | b7adb10e3986ac8334b5f304321dda6f8d135e69 (diff) |
[rubygems/rubygems] Require ext only in validate_extension, mention gemspec in warning.
https://github.com/rubygems/rubygems/commit/5e31e1a421
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3184
-rw-r--r-- | lib/rubygems/specification_policy.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/rubygems/specification_policy.rb b/lib/rubygems/specification_policy.rb index 3a30750056..1723969b79 100644 --- a/lib/rubygems/specification_policy.rb +++ b/lib/rubygems/specification_policy.rb @@ -1,4 +1,3 @@ -require 'rubygems/ext' require 'rubygems/user_interaction' class Gem::SpecificationPolicy @@ -421,13 +420,14 @@ http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard li end def validate_extensions # :nodoc: + require 'rubygems/ext' builder = Gem::Ext::Builder.new(@specification) rake_extension = @specification.extensions.any? {|s| builder.builder_for(s) == Gem::Ext::RakeBuilder } rake_dependency = @specification.dependencies.any? {|d| d.name == 'rake'} warning <<-WARNING if rake_extension && !rake_dependency -You have specified rake based extension, but rake is not added as dependency. It is recommended to add rake as a dependency since there's no guarantee rake will be already installed. +You have specified rake based extension, but rake is not added as dependency. It is recommended to add rake as a dependency in gemspec since there's no guarantee rake will be already installed. WARNING end |