diff options
| author | Kevin Newton <kddnewton@gmail.com> | 2024-03-05 08:08:16 -0500 |
|---|---|---|
| committer | git <svn-admin@ruby-lang.org> | 2024-03-06 16:42:42 +0000 |
| commit | 3bdb0fecd103a5901a7ee1ab7ff6105a4e916fe5 (patch) | |
| tree | f56eb3cb71931515fc5988e49739163373a78ac0 | |
| parent | c4388e8409bbf653b45044e4b04b703e09b47fca (diff) | |
[ruby/prism] Implement case/in for ripper translation
https://github.com/ruby/prism/commit/7f5a09f40e
| -rw-r--r-- | lib/prism/translation/ripper.rb | 23 | ||||
| -rw-r--r-- | test/prism/ripper_test.rb | 17 |
2 files changed, 21 insertions, 19 deletions
diff --git a/lib/prism/translation/ripper.rb b/lib/prism/translation/ripper.rb index e3cd300446..0872ed9f9e 100644 --- a/lib/prism/translation/ripper.rb +++ b/lib/prism/translation/ripper.rb @@ -539,7 +539,14 @@ module Prism # case foo; in bar; end # ^^^^^^^^^^^^^^^^^^^^^ def visit_case_match_node(node) - raise NoMethodError, __method__ + predicate = visit(node.predicate) + clauses = + node.conditions.reverse_each.inject(nil) do |consequent, condition| + on_in(*visit(condition), consequent) + end + + bounds(node.location) + on_case(predicate, clauses) end # class Foo; end @@ -1124,7 +1131,19 @@ module Prism # case foo; in bar; end # ^^^^^^^^^^^^^^^^^^^^^ def visit_in_node(node) - raise NoMethodError, __method__ + # This is a special case where we're not going to call on_in directly + # because we don't have access to the consequent. Instead, we'll return + # the component parts and let the parent node handle it. + pattern = visit(node.pattern) + statements = + if node.statements.nil? + bounds(node.location) + on_stmts_add(on_stmts_new, on_void_stmt) + else + visit(node.statements) + end + + [pattern, statements] end # foo[bar] += baz diff --git a/test/prism/ripper_test.rb b/test/prism/ripper_test.rb index a0b7d3a25f..4636fa6d58 100644 --- a/test/prism/ripper_test.rb +++ b/test/prism/ripper_test.rb @@ -369,18 +369,7 @@ module Prism seattlerb/call_stabby_with_braces_block.txt seattlerb/call_trailing_comma.txt seattlerb/case_in.txt - seattlerb/case_in_31.txt seattlerb/case_in_37.txt - seattlerb/case_in_42.txt - seattlerb/case_in_42_2.txt - seattlerb/case_in_47.txt - seattlerb/case_in_67.txt - seattlerb/case_in_86.txt - seattlerb/case_in_86_2.txt - seattlerb/case_in_array_pat_const.txt - seattlerb/case_in_array_pat_const2.txt - seattlerb/case_in_array_pat_paren_assign.txt - seattlerb/case_in_const.txt seattlerb/case_in_else.txt seattlerb/case_in_find.txt seattlerb/case_in_find_array.txt @@ -390,9 +379,6 @@ module Prism seattlerb/case_in_hash_pat_paren_true.txt seattlerb/case_in_hash_pat_rest.txt seattlerb/case_in_hash_pat_rest_solo.txt - seattlerb/case_in_if_unless_post_mod.txt - seattlerb/case_in_multiple.txt - seattlerb/case_in_or.txt seattlerb/class_comments.txt seattlerb/defn_arg_forward_args.txt seattlerb/defn_args_forward_args.txt @@ -509,8 +495,6 @@ module Prism seattlerb/parse_line_to_ary.txt seattlerb/parse_opt_call_args_assocs_comma.txt seattlerb/parse_opt_call_args_lit_comma.txt - seattlerb/parse_pattern_019.txt - seattlerb/parse_pattern_044.txt seattlerb/parse_pattern_051.txt seattlerb/parse_pattern_058.txt seattlerb/parse_pattern_058_2.txt @@ -730,7 +714,6 @@ module Prism whitequark/parser_bug_645.txt whitequark/parser_drops_truncated_parts_of_squiggly_heredoc.txt whitequark/parser_slash_slash_n_escaping_in_literals.txt - whitequark/pattern_matching__FILE__LINE_literals.txt whitequark/pattern_matching_blank_else.txt whitequark/pattern_matching_else.txt whitequark/pattern_matching_single_line_allowed_omission_of_parentheses.txt |