summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorshyouhei <shyouhei@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2011-08-01 06:22:05 +0000
committershyouhei <shyouhei@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2011-08-01 06:22:05 +0000
commit3237f7dc9a436a44c068e9bd8572d6e4812df772 (patch)
tree54af5e64a8ae0b9f5a1cdcf662a1151a6ab216b7
parenta429cafc4d95c0543e3fb234f1762067ee0b5304 (diff)
* test/xmlrpc/test_webrick_server.rb (Test_Webrick#setup_http_server):
XMLRPC::Client.new3(), when called without host: argument, tries to connect to a host where "localhost" resolves to. On the other hand a WEBrick::HTTPServer.new(), when called without BindAddress: argument, tries to listen all the address where getaddrinfo(AF_UNSPEC) resolves to. This is a mismatch because "localhost" might not resolve to one of those listening sockets. We would better explicitly specify "localhost" here and if failed, just skip the whole test. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r--ChangeLog12
-rw-r--r--test/xmlrpc/test_webrick_server.rb1
2 files changed, 13 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 1756438..733f5ad 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+Mon Aug 1 15:04:12 2011 URABE Shyouhei <shyouhei@ruby-lang.org>
+
+ * test/xmlrpc/test_webrick_server.rb (Test_Webrick#setup_http_server):
+ XMLRPC::Client.new3(), when called without host: argument, tries
+ to connect to a host where "localhost" resolves to. On the
+ other hand a WEBrick::HTTPServer.new(), when called without
+ BindAddress: argument, tries to listen all the address where
+ getaddrinfo(AF_UNSPEC) resolves to. This is a mismatch because
+ "localhost" might not resolve to one of those listening sockets.
+ We would better explicitly specify "localhost" here and if
+ failed, just skip the whole test.
+
Mon Aug 01 14:24:56 2011 Eric Hodel <drbrain@segment7.net>
* lib/rdoc.rb: Import RDoc 3.9.1. Fixes bugs in the RDoc::Markup
diff --git a/test/xmlrpc/test_webrick_server.rb b/test/xmlrpc/test_webrick_server.rb
index 5a9f51b..e66a467 100644
--- a/test/xmlrpc/test_webrick_server.rb
+++ b/test/xmlrpc/test_webrick_server.rb
@@ -46,6 +46,7 @@ class Test_Webrick < Test::Unit::TestCase
def setup_http_server(port, use_ssl)
option = {
+ BindAddress: "localhost",
:Port => port,
:SSLEnable => use_ssl,
}