diff options
| author | Kevin Newton <kddnewton@gmail.com> | 2024-03-05 08:42:13 -0500 |
|---|---|---|
| committer | git <svn-admin@ruby-lang.org> | 2024-03-06 16:42:44 +0000 |
| commit | 2cb75b8f1760a9aefb2221c4a6fab9304bdb3da2 (patch) | |
| tree | 96f85e2c26421ffa16726085cef6c3bbebd752cb | |
| parent | fabece2507c12f131c67d2324c1aee27ab8a5f7d (diff) | |
[ruby/prism] Implement multi target nodes for ripper translation
https://github.com/ruby/prism/commit/ceb5a5cf62
| -rw-r--r-- | lib/prism/translation/ripper.rb | 24 | ||||
| -rw-r--r-- | test/prism/ripper_test.rb | 10 |
2 files changed, 21 insertions, 13 deletions
diff --git a/lib/prism/translation/ripper.rb b/lib/prism/translation/ripper.rb index 6eb65b14ae..adc82406fa 100644 --- a/lib/prism/translation/ripper.rb +++ b/lib/prism/translation/ripper.rb @@ -1571,10 +1571,28 @@ module Prism on_module(constant_path, bodystmt) end - # foo, bar = baz - # ^^^^^^^^ + # (foo, bar), bar = qux + # ^^^^^^^^^^ def visit_multi_target_node(node) - raise NoMethodError, __method__ + bounds(node.location) + targets = + [*node.lefts, *node.rest, *node.rights].inject(on_mlhs_new) do |mlhs, target| + bounds(target.location) + + if target.is_a?(ImplicitRestNode) + on_excessed_comma # these do not get put into the targets + mlhs + else + on_mlhs_add(mlhs, visit(target)) + end + end + + if node.lparen_loc.nil? + targets + else + bounds(node.lparen_loc) + on_mlhs_paren(targets) + end end # foo, bar = baz diff --git a/test/prism/ripper_test.rb b/test/prism/ripper_test.rb index 1225f95b23..228240e005 100644 --- a/test/prism/ripper_test.rb +++ b/test/prism/ripper_test.rb @@ -290,7 +290,6 @@ module Prism embdoc_no_newline_at_end.txt emoji_method_calls.txt endless_methods.txt - for.txt global_variables.txt hashes.txt heredoc_with_escaped_newline_at_start.txt @@ -342,15 +341,10 @@ module Prism seattlerb/bug191.txt seattlerb/bug_215.txt seattlerb/bug_249.txt - seattlerb/bug_args__19.txt - seattlerb/bug_args_masgn.txt - seattlerb/bug_args_masgn2.txt - seattlerb/bug_args_masgn_outer_parens__19.txt seattlerb/bug_call_arglist_parens.txt seattlerb/bug_comma.txt seattlerb/bug_hash_args_trailing_comma.txt seattlerb/bug_hash_interp_array.txt - seattlerb/bug_masgn_right.txt seattlerb/bug_not_parens.txt seattlerb/call_args_assoc_quoted.txt seattlerb/call_args_assoc_trailing_comma.txt @@ -431,8 +425,6 @@ module Prism seattlerb/index_0_opasgn.txt seattlerb/interpolated_symbol_array_line_breaks.txt seattlerb/interpolated_word_array_line_breaks.txt - seattlerb/iter_args_2__19.txt - seattlerb/iter_args_3.txt seattlerb/lambda_do_vs_brace.txt seattlerb/lasgn_command.txt seattlerb/lasgn_middle_splat.txt @@ -641,7 +633,6 @@ module Prism whitequark/endless_method_forwarded_args_legacy.txt whitequark/endless_method_with_rescue_mod.txt whitequark/endless_method_without_args.txt - whitequark/for_mlhs.txt whitequark/forward_arg.txt whitequark/forward_arg_with_open_args.txt whitequark/forward_args_legacy.txt @@ -686,7 +677,6 @@ module Prism whitequark/pattern_matching_blank_else.txt whitequark/pattern_matching_else.txt whitequark/pattern_matching_single_line_allowed_omission_of_parentheses.txt - whitequark/procarg0.txt whitequark/resbody_var.txt whitequark/rescue_else.txt whitequark/rescue_else_ensure.txt |