summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2020-06-12 11:37:38 +0200
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2020-06-15 21:20:37 +0900
commit2b4abcff90a3c4c4d07e0929e1f99afbfeb57a4e (patch)
treeb63dfe2f7ee6ad27159b607a127f844d9900986f
parentafce7eb39ec58f9ec65b3cf53059a4bc3bd58cbd (diff)
Deprecate `Gem::Util.silent_system`
There's better tools for this job.
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/3229
-rw-r--r--lib/rubygems/util.rb11
-rw-r--r--test/rubygems/test_gem_util.rb6
2 files changed, 15 insertions, 2 deletions
diff --git a/lib/rubygems/util.rb b/lib/rubygems/util.rb
index dcd7fc2b47..814a4075fd 100644
--- a/lib/rubygems/util.rb
+++ b/lib/rubygems/util.rb
@@ -1,8 +1,11 @@
# frozen_string_literal: true
+require 'rubygems/deprecate'
+
##
# This module contains various utility methods as module methods.
module Gem::Util
+
##
# Zlib::GzipReader wrapper that unzips +data+.
@@ -67,6 +70,14 @@ module Gem::Util
system(*(cmds << opt))
end
+ class << self
+
+ extend Gem::Deprecate
+
+ rubygems_deprecate :silent_system
+
+ end
+
##
# Enumerates the parents of +directory+.
diff --git a/test/rubygems/test_gem_util.rb b/test/rubygems/test_gem_util.rb
index cf90350763..5866aa7b99 100644
--- a/test/rubygems/test_gem_util.rb
+++ b/test/rubygems/test_gem_util.rb
@@ -15,8 +15,10 @@ class TestGemUtil < Gem::TestCase
def test_silent_system
skip if Gem.java_platform?
- assert_silent do
- Gem::Util.silent_system(*ruby_with_rubygems_in_load_path, '-e', 'puts "hello"; warn "hello"')
+ Gem::Deprecate.skip_during do
+ assert_silent do
+ Gem::Util.silent_system(*ruby_with_rubygems_in_load_path, '-e', 'puts "hello"; warn "hello"')
+ end
end
end