diff options
| author | Stan Lo <stan001212@gmail.com> | 2024-02-25 15:08:27 +0800 |
|---|---|---|
| committer | git <svn-admin@ruby-lang.org> | 2024-02-25 07:08:34 +0000 |
| commit | 2721a64e4192fee250442cd6157c5a85908a20d4 (patch) | |
| tree | 32c41cb8de8491c0ab6fb6fc311c4238ec816ad8 | |
| parent | 7356067b73f9f1a4c8a06546611ec242af1fa192 (diff) | |
[ruby/reline] Use gray and white as the default dialog theme
(https://github.com/ruby/reline/pull/637)
I think this has a few benefits:
1. Most terminal themes generally don't change or pick similar colors
for their black and white colors, so it's more likely to be consistent
across terminals/themes.
2. They don't have the potential color-blind issues that other color options
may have.
3. We won't need additional changes for no color mode.
https://github.com/ruby/reline/commit/6579a0a737
| -rw-r--r-- | lib/reline/face.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/reline/face.rb b/lib/reline/face.rb index e18ec957e8..d07196e2e7 100644 --- a/lib/reline/face.rb +++ b/lib/reline/face.rb @@ -186,9 +186,9 @@ class Reline::Face conf.define :scrollbar, style: :reset end config(:completion_dialog) do |conf| - conf.define :default, foreground: :white, background: :cyan - conf.define :enhanced, foreground: :white, background: :magenta - conf.define :scrollbar, foreground: :white, background: :cyan + conf.define :default, foreground: :bright_white, background: :gray + conf.define :enhanced, foreground: :black, background: :white + conf.define :scrollbar, foreground: :white, background: :gray end end |