summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Newton <kddnewton@gmail.com>2024-01-11 14:14:19 -0500
committergit <svn-admin@ruby-lang.org>2024-01-11 19:14:25 +0000
commit242dc537f93a0e11d91e729823cf8df2caec6abd (patch)
tree51200a5ffe68c0668ae1c3f847f901ed057cf6a3
parent6ff9f1aa51bf53024a7545844ff0f3f53111403f (diff)
[ruby/prism] Exclude encodings that are dynamic
https://github.com/ruby/prism/commit/6749146c0e
-rw-r--r--prism/encoding.c7
-rw-r--r--test/prism/encoding_test.rb4
2 files changed, 1 insertions, 10 deletions
diff --git a/prism/encoding.c b/prism/encoding.c
index 2c6d7c9777..2210d71411 100644
--- a/prism/encoding.c
+++ b/prism/encoding.c
@@ -5022,10 +5022,6 @@ pm_encoding_find(const uint8_t *start, const uint8_t *end) {
ENCODING2("EUC-CN", "eucCN", PM_ENCODING_GB2312);
ENCODING2("EUC-TW", "eucTW", PM_ENCODING_EUC_TW);
ENCODING1("Emacs-Mule", PM_ENCODING_EMACS_MULE);
- ENCODING1("external", PM_ENCODING_UTF_8);
- break;
- case 'F': case 'f':
- ENCODING1("filesystem", PM_ENCODING_UTF_8);
break;
case 'G': case 'g':
ENCODING1("GBK", PM_ENCODING_GBK);
@@ -5071,9 +5067,6 @@ pm_encoding_find(const uint8_t *start, const uint8_t *end) {
ENCODING1("KOI8-R", PM_ENCODING_KOI8_R);
ENCODING1("KOI8-U", PM_ENCODING_KOI8_U);
break;
- case 'L': case 'l':
- ENCODING1("locale", PM_ENCODING_UTF_8);
- break;
case 'M': case 'm':
ENCODING1("macCentEuro", PM_ENCODING_MAC_CENT_EURO);
ENCODING1("macCroatian", PM_ENCODING_MAC_CROATIAN);
diff --git a/test/prism/encoding_test.rb b/test/prism/encoding_test.rb
index e4678c6f82..e755cdaba2 100644
--- a/test/prism/encoding_test.rb
+++ b/test/prism/encoding_test.rb
@@ -137,9 +137,7 @@ module Prism
# These test that we're correctly parsing codepoints for each alias of each
# encoding that prism supports.
encodings.each do |encoding, range|
- encoding.names.each do |name|
- next if name == "locale"
-
+ (encoding.names - %w[external internal filesystem locale]).each do |name|
define_method(:"test_encoding_#{name}") do
assert_encoding(encoding, name, range)
end