diff options
author | nagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2013-12-21 07:38:21 +0000 |
---|---|---|
committer | nagachika <nagachika@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2013-12-21 07:38:21 +0000 |
commit | 206a2879172c02a3b5ce06e3a0de849eb05eecab (patch) | |
tree | c6891b951d1cdfbef6bc0c99db78590460576c30 | |
parent | a46136856c1cab68cbe3279cf46a5409ad6d3f2d (diff) |
merge revision(s) 43994: [Backport #9205]
* gc.c (finalize_deferred): flush all deferred finalizers while other
finalizers can get ready to run newly by lazy sweep.
[ruby-core:58833] [Bug #9205]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@44319 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | ChangeLog | 6 | ||||
-rw-r--r-- | gc.c | 5 | ||||
-rw-r--r-- | test/ruby/test_gc.rb | 14 | ||||
-rw-r--r-- | version.h | 2 |
4 files changed, 23 insertions, 4 deletions
@@ -1,3 +1,9 @@ +Sat Dec 21 16:16:56 2013 Nobuyoshi Nakada <nobu@ruby-lang.org> + + * gc.c (finalize_deferred): flush all deferred finalizers while other + finalizers can get ready to run newly by lazy sweep. + [ruby-core:58833] [Bug #9205] + Sat Dec 21 16:07:00 2013 Nobuyoshi Nakada <nobu@ruby-lang.org> * ruby_atomic.h (ATOMIC_PTR_EXCHANGE): atomic exchange function for @@ -1443,10 +1443,9 @@ finalize_list(rb_objspace_t *objspace, RVALUE *p) static void finalize_deferred(rb_objspace_t *objspace) { - RVALUE *p = deferred_final_list; - deferred_final_list = 0; + RVALUE *p; - if (p) { + while ((p = ATOMIC_PTR_EXCHANGE(deferred_final_list, 0)) != 0) { finalize_list(objspace, p); } } diff --git a/test/ruby/test_gc.rb b/test/ruby/test_gc.rb index e3186c9a44..ba193cec84 100644 --- a/test/ruby/test_gc.rb +++ b/test/ruby/test_gc.rb @@ -160,4 +160,18 @@ class TestGc < Test::Unit::TestCase assert base_length < GC.stat[:heap_length] eom end + + def test_sweep_in_finalizer + bug9205 = '[ruby-core:58833] [Bug #9205]' + 100.times do + assert_ruby_status([], <<-'end;', bug9205) + raise_proc = proc do |id| + GC.start + end + 1000.times do + ObjectSpace.define_finalizer(Object.new, raise_proc) + end + end; + end + end end @@ -1,6 +1,6 @@ #define RUBY_VERSION "2.0.0" #define RUBY_RELEASE_DATE "2013-12-21" -#define RUBY_PATCHLEVEL 364 +#define RUBY_PATCHLEVEL 365 #define RUBY_RELEASE_YEAR 2013 #define RUBY_RELEASE_MONTH 12 |