summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorなつき <i@ntk.me>2024-01-17 14:57:09 -0800
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2024-01-24 13:55:42 +0900
commit1e519abe21466c3846be7da37c3c8e461fc4efb0 (patch)
tree64627cdc66b927aa70ce12f41207dd4504b05e98
parent772afa00b5109f55c1d8359c688aca4063818549 (diff)
[rubygems/rubygems] Fix rake extension warning
https://github.com/rubygems/rubygems/commit/04973e349c
-rw-r--r--lib/rubygems/specification_policy.rb4
-rw-r--r--test/rubygems/test_gem_specification.rb4
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/rubygems/specification_policy.rb b/lib/rubygems/specification_policy.rb
index 77d5863819..4088fb621a 100644
--- a/lib/rubygems/specification_policy.rb
+++ b/lib/rubygems/specification_policy.rb
@@ -497,10 +497,10 @@ You have specified rust based extension, but Cargo.lock is not part of the gem f
def validate_rake_extensions(builder) # :nodoc:
rake_extension = @specification.extensions.any? {|s| builder.builder_for(s) == Gem::Ext::RakeBuilder }
- rake_dependency = @specification.dependencies.any? {|d| d.name == "rake" }
+ rake_dependency = @specification.dependencies.any? {|d| d.name == "rake" && d.type == :runtime }
warning <<-WARNING if rake_extension && !rake_dependency
-You have specified rake based extension, but rake is not added as dependency. It is recommended to add rake as a dependency in gemspec since there's no guarantee rake will be already installed.
+You have specified rake based extension, but rake is not added as runtime dependency. It is recommended to add rake as a runtime dependency in gemspec since there's no guarantee rake will be already installed.
WARNING
end
diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb
index 5f0546b93d..ca5e8cef3b 100644
--- a/test/rubygems/test_gem_specification.rb
+++ b/test/rubygems/test_gem_specification.rb
@@ -2727,7 +2727,7 @@ duplicate dependency on c (>= 1.2.3, development), (~> 1.2) use:
@a1.validate
end
- assert_match(/add rake as a dependency/, @ui.error)
+ assert_match(/add rake as a runtime dependency/, @ui.error)
end
end
@@ -2743,7 +2743,7 @@ duplicate dependency on c (>= 1.2.3, development), (~> 1.2) use:
@a1.validate
end
- refute_match(/add rake as a dependency/, @ui.error)
+ refute_match(/add rake as a runtime dependency/, @ui.error)
end
end