summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTakashi Kokubun <takashikkbn@gmail.com>2025-10-29 17:28:01 -0700
committerTakashi Kokubun <takashikkbn@gmail.com>2025-10-29 18:33:44 -0700
commit02c9ffd16b3324449cf8e6612a9896148a1be435 (patch)
treec3a7c28eed0e48dbda12065f3850edfb4ae68a79
parent78e4a36fb17853e74978addedf663851a124bff5 (diff)
ZJIT: Enable comments for --zjit-debug on dev builds
I wanted to see comments on test_zjit.rb failures.
-rw-r--r--zjit/src/backend/lir.rs7
1 files changed, 6 insertions, 1 deletions
diff --git a/zjit/src/backend/lir.rs b/zjit/src/backend/lir.rs
index 005df140b8..cad369357f 100644
--- a/zjit/src/backend/lir.rs
+++ b/zjit/src/backend/lir.rs
@@ -2255,7 +2255,12 @@ impl Assembler {
/// when not dumping disassembly.
macro_rules! asm_comment {
($asm:expr, $($fmt:tt)*) => {
- if $crate::options::get_option!(dump_disasm) || $crate::options::get_option!(dump_lir).is_some() {
+ // If --zjit-dump-disasm or --zjit-dump-lir is given, enrich them with comments.
+ // Also allow --zjit-debug on dev builds to enable comments since dev builds dump LIR on panic.
+ let enable_comment = $crate::options::get_option!(dump_disasm) ||
+ $crate::options::get_option!(dump_lir).is_some() ||
+ (cfg!(debug_assertions) && $crate::options::get_option!(debug));
+ if enable_comment {
$asm.push_insn(crate::backend::lir::Insn::Comment(format!($($fmt)*)));
}
};