diff options
| author | Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com> | 2020-10-20 10:37:47 -0400 |
|---|---|---|
| committer | Alan Wu <XrXr@users.noreply.github.com> | 2021-10-20 18:19:25 -0400 |
| commit | 008551decb7481c8d8a7c870a43e0ea450041aa5 (patch) | |
| tree | 6eb1c1edbae3810e149adf6d684440bdddc90755 | |
| parent | a88d6207dd87b53f54debb1a3cf044da60b82fb3 (diff) | |
Commit before merge.
| -rw-r--r-- | ujit_compile.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/ujit_compile.c b/ujit_compile.c index 666963b11e..1bb7b407c8 100644 --- a/ujit_compile.c +++ b/ujit_compile.c @@ -582,8 +582,9 @@ gen_opt_send_without_block(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx) test(cb, flags_opnd, imm_opnd(IMEMO_FL_USER5)); jnz_ptr(cb, side_exit); - - // NOTE: stack frame setup may not be needed for some C functions + // IDEA: stack frame setup may not be needed for some C functions + // We could profile the most called C functions and identify which are safe + // This may help us eliminate stack overflow checks as well // TODO: do we need this check? //vm_check_frame(type, specval, cref_or_me, iseq); @@ -605,6 +606,8 @@ gen_opt_send_without_block(codeblock_t* cb, codeblock_t* ocb, ctx_t* ctx) // FIXME: for now, we hardcode ec // TODO: hardcode EC + //mov(cb, RDI, const_ptr_opnd(rb_current_execution_context())); + // Allocate a new CFP //ec->cfp--; |