blob: c6681692452011a7afa2d7905fd5727a561d13f9 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
|
# frozen_string_literal: true
require_relative "test_helper"
module Prism
class RedundantReturnTest < TestCase
def test_statements
assert_redundant_return("def foo; return; end")
refute_redundant_return("def foo; return; 1; end")
end
def test_begin_implicit
assert_redundant_return("def foo; return; rescue; end")
refute_redundant_return("def foo; return; 1; rescue; end")
refute_redundant_return("def foo; return; rescue; else; end")
end
def test_begin_explicit
assert_redundant_return("def foo; begin; return; rescue; end; end")
refute_redundant_return("def foo; begin; return; 1; rescue; end; end")
refute_redundant_return("def foo; begin; return; rescue; else; end; end")
end
def test_if
assert_redundant_return("def foo; return if bar; end")
end
def test_unless
assert_redundant_return("def foo; return unless bar; end")
end
def test_else
assert_redundant_return("def foo; if bar; baz; else; return; end; end")
end
def test_case_when
assert_redundant_return("def foo; case bar; when baz; return; end; end")
end
def test_case_else
assert_redundant_return("def foo; case bar; when baz; else; return; end; end")
end
def test_case_match_in
assert_redundant_return("def foo; case bar; in baz; return; end; end")
end
def test_case_match_else
assert_redundant_return("def foo; case bar; in baz; else; return; end; end")
end
private
def assert_redundant_return(source)
assert find_return(source).redundant?
end
def refute_redundant_return(source)
refute find_return(source).redundant?
end
def find_return(source)
queue = [Prism.parse(source).value]
while (current = queue.shift)
return current if current.is_a?(ReturnNode)
queue.concat(current.compact_child_nodes)
end
flunk "Could not find return node in #{node.inspect}"
end
end
end
|
