summaryrefslogtreecommitdiff
path: root/spec/bundler/install/gemfile/ruby_spec.rb
blob: b64d633fd3197b5afbe76c21dab5f9d6f4dacfdc (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
# frozen_string_literal: true

RSpec.describe "ruby requirement" do
  def locked_ruby_version
    Bundler::RubyVersion.from_string(Bundler::LockfileParser.new(File.read(bundled_app_lock)).ruby_version)
  end

  # As discovered by https://github.com/rubygems/bundler/issues/4147, there is
  # no test coverage to ensure that adding a gem is possible with a ruby
  # requirement. This test verifies the fix, committed in bfbad5c5.
  it "allows adding gems" do
    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby "#{Gem.ruby_version}"
      gem "rack"
    G

    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby "#{Gem.ruby_version}"
      gem "rack"
      gem "rack-obama"
    G

    expect(the_bundle).to include_gems "rack-obama 1.0"
  end

  it "allows removing the ruby version requirement" do
    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby "~> #{Gem.ruby_version}"
      gem "rack"
    G

    expect(lockfile).to include("RUBY VERSION")

    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      gem "rack"
    G

    expect(the_bundle).to include_gems "rack 1.0.0"
    expect(lockfile).not_to include("RUBY VERSION")
  end

  it "allows changing the ruby version requirement to something compatible" do
    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby ">= #{current_ruby_minor}"
      gem "rack"
    G

    allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
    expect(locked_ruby_version).to eq(Bundler::RubyVersion.system)

    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby ">= #{Gem.ruby_version}"
      gem "rack"
    G

    expect(the_bundle).to include_gems "rack 1.0.0"
    expect(locked_ruby_version).to eq(Bundler::RubyVersion.system)
  end

  it "allows changing the ruby version requirement to something incompatible" do
    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby ">= 1.0.0"
      gem "rack"
    G

    lockfile <<~L
      GEM
        remote: #{file_uri_for(gem_repo1)}/
        specs:
          rack (1.0.0)

      PLATFORMS
        #{lockfile_platforms}

      DEPENDENCIES
        rack

      RUBY VERSION
         ruby 2.1.4p422

      BUNDLED WITH
         #{Bundler::VERSION}
    L

    allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)

    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby ">= #{current_ruby_minor}"
      gem "rack"
    G

    expect(the_bundle).to include_gems "rack 1.0.0"
    expect(locked_ruby_version).to eq(Bundler::RubyVersion.system)
  end

  it "allows requirements with trailing whitespace" do
    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby "#{Gem.ruby_version}\\n \t\\n"
      gem "rack"
    G

    expect(the_bundle).to include_gems "rack 1.0.0"
  end

  it "fails gracefully with malformed requirements" do
    install_gemfile <<-G, raise_on_error: false
      source "#{file_uri_for(gem_repo1)}"
      ruby ">= 0", "-.\\0"
      gem "rack"
    G

    expect(err).to include("There was an error parsing") # i.e. DSL error, not error template
  end

  it "allows picking up ruby version from a file" do
    create_file ".ruby-version", Gem.ruby_version.to_s

    install_gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby file: ".ruby-version"
      gem "rack"
    G

    expect(lockfile).to include("RUBY VERSION")
  end

  it "reads the ruby version file from the right folder when nested Gemfiles are involved" do
    create_file ".ruby-version", Gem.ruby_version.to_s

    gemfile <<-G
      source "#{file_uri_for(gem_repo1)}"
      ruby file: ".ruby-version"
      gem "rack"
    G

    nested_dir = bundled_app(".ruby-lsp")

    FileUtils.mkdir nested_dir

    create_file ".ruby-lsp/Gemfile", <<-G
      eval_gemfile(File.expand_path("../Gemfile", __dir__))
    G

    bundle "install", dir: nested_dir

    expect(bundled_app(".ruby-lsp/Gemfile.lock").read).to include("RUBY VERSION")
  end
end