1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
|
use std::sync::atomic::AtomicUsize;
use std::sync::atomic::Ordering;
use std::sync::Mutex;
use mmtk::scheduler::GCWork;
use mmtk::scheduler::GCWorker;
use mmtk::scheduler::WorkBucketStage;
use mmtk::util::ObjectReference;
use mmtk::vm::ObjectTracerContext;
use crate::abi::GCThreadTLS;
use crate::upcalls;
use crate::Ruby;
pub struct WeakProcessor {
non_parallel_obj_free_candidates: Mutex<Vec<ObjectReference>>,
parallel_obj_free_candidates: Vec<Mutex<Vec<ObjectReference>>>,
parallel_obj_free_candidates_counter: AtomicUsize,
/// Objects that needs `obj_free` called when dying.
/// If it is a bottleneck, replace it with a lock-free data structure,
/// or add candidates in batch.
weak_references: Mutex<Vec<ObjectReference>>,
}
impl Default for WeakProcessor {
fn default() -> Self {
Self::new()
}
}
impl WeakProcessor {
pub fn new() -> Self {
Self {
non_parallel_obj_free_candidates: Mutex::new(Vec::new()),
parallel_obj_free_candidates: vec![Mutex::new(Vec::new())],
parallel_obj_free_candidates_counter: AtomicUsize::new(0),
weak_references: Mutex::new(Vec::new()),
}
}
pub fn init_parallel_obj_free_candidates(&mut self, num_workers: usize) {
debug_assert_eq!(self.parallel_obj_free_candidates.len(), 1);
for _ in 1..num_workers {
self.parallel_obj_free_candidates
.push(Mutex::new(Vec::new()));
}
}
/// Add an object as a candidate for `obj_free`.
///
/// Multiple mutators can call it concurrently, so it has `&self`.
pub fn add_obj_free_candidate(&self, object: ObjectReference, can_parallel_free: bool) {
if can_parallel_free {
// Newly allocated objects are placed in parallel_obj_free_candidates using
// round-robin. This may not be ideal for load balancing.
let idx = self
.parallel_obj_free_candidates_counter
.fetch_add(1, Ordering::Relaxed)
% self.parallel_obj_free_candidates.len();
self.parallel_obj_free_candidates[idx]
.lock()
.unwrap()
.push(object);
} else {
self.non_parallel_obj_free_candidates
.lock()
.unwrap()
.push(object);
}
}
pub fn get_all_obj_free_candidates(&self) -> Vec<ObjectReference> {
// let mut obj_free_candidates = self.obj_free_candidates.lock().unwrap();
let mut all_obj_free_candidates = self
.non_parallel_obj_free_candidates
.lock()
.unwrap()
.to_vec();
for candidates_mutex in &self.parallel_obj_free_candidates {
all_obj_free_candidates.extend(candidates_mutex.lock().unwrap().to_vec());
}
std::mem::take(all_obj_free_candidates.as_mut())
}
pub fn add_weak_reference(&self, object: ObjectReference) {
let mut weak_references = self.weak_references.lock().unwrap();
weak_references.push(object);
}
pub fn process_weak_stuff(
&self,
worker: &mut GCWorker<Ruby>,
_tracer_context: impl ObjectTracerContext<Ruby>,
) {
worker.add_work(
WorkBucketStage::VMRefClosure,
ProcessNonParallelObjFreeCanadidates {},
);
for index in 0..self.parallel_obj_free_candidates.len() {
worker.add_work(
WorkBucketStage::VMRefClosure,
ProcessParallelObjFreeCandidates { index },
);
}
worker.add_work(WorkBucketStage::VMRefClosure, ProcessWeakReferences);
worker.add_work(WorkBucketStage::Prepare, UpdateFinalizerObjIdTables);
let global_tables_count = (crate::upcalls().global_tables_count)();
let work_packets = (0..global_tables_count)
.map(|i| Box::new(UpdateGlobalTables { idx: i }) as _)
.collect();
worker.scheduler().work_buckets[WorkBucketStage::VMRefClosure].bulk_add(work_packets);
worker.scheduler().work_buckets[WorkBucketStage::VMRefClosure]
.bulk_add(vec![Box::new(UpdateWbUnprotectedObjectsList) as _]);
}
}
fn process_obj_free_candidates(obj_free_candidates: &mut Vec<ObjectReference>) {
// Process obj_free
let mut new_candidates = Vec::new();
for object in obj_free_candidates.iter().copied() {
if object.is_reachable() {
// Forward and add back to the candidate list.
let new_object = object.forward();
trace!("Forwarding obj_free candidate: {object} -> {new_object}");
new_candidates.push(new_object);
} else {
(upcalls().call_obj_free)(object);
}
}
*obj_free_candidates = new_candidates;
}
struct ProcessParallelObjFreeCandidates {
index: usize,
}
impl GCWork<Ruby> for ProcessParallelObjFreeCandidates {
fn do_work(&mut self, _worker: &mut GCWorker<Ruby>, _mmtk: &'static mmtk::MMTK<Ruby>) {
let mut obj_free_candidates = crate::binding().weak_proc.parallel_obj_free_candidates
[self.index]
.try_lock()
.expect("Lock for parallel_obj_free_candidates should not be held");
process_obj_free_candidates(&mut obj_free_candidates);
}
}
struct ProcessNonParallelObjFreeCanadidates;
impl GCWork<Ruby> for ProcessNonParallelObjFreeCanadidates {
fn do_work(&mut self, _worker: &mut GCWorker<Ruby>, _mmtk: &'static mmtk::MMTK<Ruby>) {
let mut obj_free_candidates = crate::binding()
.weak_proc
.non_parallel_obj_free_candidates
.try_lock()
.expect("Lock for non_parallel_obj_free_candidates should not be held");
process_obj_free_candidates(&mut obj_free_candidates);
}
}
struct ProcessWeakReferences;
impl GCWork<Ruby> for ProcessWeakReferences {
fn do_work(&mut self, worker: &mut GCWorker<Ruby>, _mmtk: &'static mmtk::MMTK<Ruby>) {
if crate::mmtk().get_plan().current_gc_may_move_object() {
let gc_tls: &mut GCThreadTLS = unsafe { GCThreadTLS::from_vwt_check(worker.tls) };
let visit_object = |_worker, target_object: ObjectReference, _pin| {
debug_assert!(
mmtk::memory_manager::is_mmtk_object(target_object.to_raw_address()).is_some(),
"Destination is not an MMTk object"
);
target_object
.get_forwarded_object()
.unwrap_or(target_object)
};
gc_tls
.object_closure
.set_temporarily_and_run_code(visit_object, || {
self.process_weak_references(true);
})
} else {
self.process_weak_references(false);
}
}
}
impl ProcessWeakReferences {
fn process_weak_references(&mut self, moving_gc: bool) {
let mut weak_references = crate::binding()
.weak_proc
.weak_references
.try_lock()
.expect("Mutators should not be holding the lock.");
weak_references.retain_mut(|object_ptr| {
let object = object_ptr.get_forwarded_object().unwrap_or(*object_ptr);
if object != *object_ptr {
*object_ptr = object;
}
if object.is_reachable() {
(upcalls().handle_weak_references)(object, moving_gc);
true
} else {
false
}
});
}
}
trait GlobalTableProcessingWork {
fn process_table(&mut self);
fn do_work(&mut self, worker: &mut GCWorker<Ruby>, _mmtk: &'static mmtk::MMTK<Ruby>) {
let gc_tls = unsafe { GCThreadTLS::from_vwt_check(worker.tls) };
// `hash_foreach_replace` depends on `gb_object_moved_p` which has to have the semantics
// of `trace_object` due to the way it is used in `UPDATE_IF_MOVED`.
let forward_object = |_worker, object: ObjectReference, _pin| {
debug_assert!(
mmtk::memory_manager::is_mmtk_object(object.to_raw_address()).is_some(),
"{object} is not an MMTk object"
);
let result = object.forward();
trace!("Forwarding reference: {object} -> {result}");
result
};
gc_tls
.object_closure
.set_temporarily_and_run_code(forward_object, || {
self.process_table();
});
}
}
struct UpdateFinalizerObjIdTables;
impl GlobalTableProcessingWork for UpdateFinalizerObjIdTables {
fn process_table(&mut self) {
(crate::upcalls().update_finalizer_table)();
}
}
impl GCWork<Ruby> for UpdateFinalizerObjIdTables {
fn do_work(&mut self, worker: &mut GCWorker<Ruby>, mmtk: &'static mmtk::MMTK<Ruby>) {
GlobalTableProcessingWork::do_work(self, worker, mmtk);
}
}
struct UpdateGlobalTables {
idx: i32,
}
impl GlobalTableProcessingWork for UpdateGlobalTables {
fn process_table(&mut self) {
(crate::upcalls().update_global_tables)(self.idx)
}
}
impl GCWork<Ruby> for UpdateGlobalTables {
fn do_work(&mut self, worker: &mut GCWorker<Ruby>, mmtk: &'static mmtk::MMTK<Ruby>) {
GlobalTableProcessingWork::do_work(self, worker, mmtk);
}
}
struct UpdateWbUnprotectedObjectsList;
impl GCWork<Ruby> for UpdateWbUnprotectedObjectsList {
fn do_work(&mut self, _worker: &mut GCWorker<Ruby>, _mmtk: &'static mmtk::MMTK<Ruby>) {
let mut objects = crate::binding().wb_unprotected_objects.try_lock().expect(
"Someone is holding the lock of wb_unprotected_objects during weak processing phase?",
);
let old_objects = std::mem::take(&mut *objects);
debug!("Updating {} WB-unprotected objects", old_objects.len());
for object in old_objects {
if object.is_reachable() {
// Forward and add back to the candidate list.
let new_object = object.forward();
trace!("Forwarding WB-unprotected object: {object} -> {new_object}");
objects.insert(new_object);
} else {
trace!("Removing WB-unprotected object from list: {object}");
}
}
debug!("Retained {} live WB-unprotected objects.", objects.len());
}
}
// Provide a shorthand `object.forward()`.
trait Forwardable {
fn forward(&self) -> Self;
}
impl Forwardable for ObjectReference {
fn forward(&self) -> Self {
self.get_forwarded_object().unwrap_or(*self)
}
}
|