| Age | Commit message (Collapse) | Author |
|
This reverts commit https://github.com/ruby/did_you_mean/commit/15d7b0bfa573.
https://github.com/ruby/did_you_mean/commit/86a7daca19
|
|
https://github.com/ruby/did_you_mean/commit/a7a438ae27
|
|
https://github.com/ruby/did_you_mean/commit/15d7b0bfa5
|
|
* Added `Ractor::Port`
* `Ractor::Port#receive` (support multi-threads)
* `Rcator::Port#close`
* `Ractor::Port#closed?`
* Added some methods
* `Ractor#join`
* `Ractor#value`
* `Ractor#monitor`
* `Ractor#unmonitor`
* Removed some methods
* `Ractor#take`
* `Ractor.yield`
* Change the spec
* `Racotr.select`
You can wait for multiple sequences of messages with `Ractor::Port`.
```ruby
ports = 3.times.map{ Ractor::Port.new }
ports.map.with_index do |port, ri|
Ractor.new port,ri do |port, ri|
3.times{|i| port << "r#{ri}-#{i}"}
end
end
p ports.each{|port| pp 3.times.map{port.receive}}
```
In this example, we use 3 ports, and 3 Ractors send messages to them respectively.
We can receive a series of messages from each port.
You can use `Ractor#value` to get the last value of a Ractor's block:
```ruby
result = Ractor.new do
heavy_task()
end.value
```
You can wait for the termination of a Ractor with `Ractor#join` like this:
```ruby
Ractor.new do
some_task()
end.join
```
`#value` and `#join` are similar to `Thread#value` and `Thread#join`.
To implement `#join`, `Ractor#monitor` (and `Ractor#unmonitor`) is introduced.
This commit changes `Ractor.select()` method.
It now only accepts ports or Ractors, and returns when a port receives a message or a Ractor terminates.
We removes `Ractor.yield` and `Ractor#take` because:
* `Ractor::Port` supports most of similar use cases in a simpler manner.
* Removing them significantly simplifies the code.
We also change the internal thread scheduler code (thread_pthread.c):
* During barrier synchronization, we keep the `ractor_sched` lock to avoid deadlocks.
This lock is released by `rb_ractor_sched_barrier_end()`
which is called at the end of operations that require the barrier.
* fix potential deadlock issues by checking interrupts just before setting UBF.
https://bugs.ruby-lang.org/issues/21262
Notes:
Merged: https://github.com/ruby/ruby/pull/13445
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/12531
|
|
[Feature #16495]
|
|
Ruby 3.3
(https://github.com/ruby/did_you_mean/pull/184)
This change accepts the following change of the message of NameError in
a test.
https://bugs.ruby-lang.org/issues/18285#note-37
```
old: undefined method `sizee' for #<File:...>
new: undefined method `sizee' for an instance of File
```
|
|
(https://github.com/ruby/did_you_mean/pull/180)
* Do not suggest #name= for #name and vice versa
* Avoid allocating unnecessary MatchData
Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
|
|
https://github.com/ruby/did_you_mean/commit/c3fc412f6f
|
|
|
|
|
|
https://github.com/ruby/did_you_mean/commit/8faba54b2d3ec9aa570691775f143801308c5b2f
|
|
|
|
This reverts commit feaf4fbc3fa16382fbd07158c448c7b5bdae78b5.
This reverts commit 0d4bfbdbe1f880c712b3e60de5fce423e6096f8d.
This reverts commit ac4e0978ee4358430396403065eabe1aca05784f.
|
|
|
|
|
|
This reverts commit 4560091b1c99ab33db0d653b9dd2d977fe4676d5.
This reverts commit a6f76122a2395bd914daa0aa04fb5a6ce4e0c045.
This reverts commit e59b18a6379c55f15ccda85c27d6997d44ef5293.
This reverts commit 505dfae05d56d844ea150676edb87850a406d071.
|
|
|
|
|
|
|
|
This reverts commit e22d293e06966733e71a7fd9725eee06c03d0177.
|
|
|
|
Fixes #160
https://github.com/ruby/did_you_mean/commit/93df310873
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/4800
|
|
divisions"
```
test/did_you_mean/spell_checking/test_uncorrectable_name_check.rb:13: warning: ambiguity between regexp and two divisions: wrap regexp in parentheses or add a space after `/' operator
```
http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20210630T033005Z.log.html.gz#test-all
https://github.com/ruby/did_you_mean/commit/842ede4186
|
|
... instead of exact matching. I'm now creating a built-in gem that
modifies Exception's error message, so the expectation value is changed.
IMO, it is good to check that did_you_mean suggestion is NOT added in
the uncorrectable case.
https://github.com/ruby/did_you_mean/commit/ebe88ec4d2
|
|
This reverts commit 379a5ca539af0e954b1cdf63b9365ad208b9c7f3.
This "typo" is intentional to test the transposition detection by
did_you_mean.
|
|
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3135
|
|
This reverts commit 946dadd3f479198e87873a863d15c7660a8e2b56,
which broke `TestGemRequire` and others.
|
|
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/2894
|
|
test/did_you_mean/spell_checking/test_class_name_check.rb
Notes:
Merged: https://github.com/ruby/ruby/pull/2880
|
|
https://github.com/ruby/did_you_mean/commit/dd1dd86e6c3188c36224d5dd4389676e6653a727
|
|
Fixed misspellings reported at [Bug #16437], for default gems.
|
|
https://github.com/ruby/ruby/commit/de74d2c3b0005048a2c4433bde68b9be10c86f01/checks?check_suite_id=336910877#step:19:131
```
Leaked file descriptor: NameErrorExtensionTest#test_correctable_error_objects_are_dumpable: 7 : #<File:test_name_error_extension.rb>
```
Notes:
Merged: https://github.com/ruby/ruby/pull/2712
|
|
|
|
23d7f4c5e1ce164e78d77de694dccc0c41f6de3d breaks a test which expect
to match error message. To avoid this failure, use #strip for expect
and actual results.
|
|
|
|
At the moment, there are some problems with regard to bundler + did_you_mean because of did_you_mean being a bundled gem. Since the vendored version of thor inside bundler and ruby itself explicitly requires did_you_mean, it can become difficult to load it when using Bundler.setup. See this issue: https://github.com/yuki24/did_you_mean/issues/117#issuecomment-482733159 for more details.
Notes:
Merged: https://github.com/ruby/ruby/pull/2689
|