Age | Commit message (Collapse) | Author |
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3982
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3930
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3901
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3864
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3659
|
|
In an executable script, the shebang line should be the first line (the
file needs to start with the bytes 0x23 0x21). Putting a comment above
it will break the script.
(Regression test included per @deivid-rodriguez)
https://github.com/rubygems/rubygems/commit/962e669feb
Notes:
Merged: https://github.com/ruby/ruby/pull/3599
|
|
s/overriden/overridden/
|
|
The newly added specs needs to be tagged as
:readline, otherwise they fail on Windows with
the backtrace: `ZeroDivisionError: divided by 0`.
Such issues are already being skipped on Windows.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/391f860af4
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Since this PR was made because we missed checking
RuboCop offenses with different flags, therefore
adding tests so that all flag combinations are
tested.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/d08250efc2
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
The Gemfile wasn't properly put in the last commit.
As a result, Layout/EmptyLines inspected an offense
in the Gemfile.
This also fixes the spec w.r.t change in the task
default.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/d1418fddd3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/27e0e4ecb6
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Since our helpers now raise by default if the subcommand fails, these
will never actually fail and are not necessary.
https://github.com/rubygems/rubygems/commit/6153b9321e
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
ruby_core has an 'ast.rb' file that gets in the
middle and breaks this spec, so it's better we skip
this test on this workflow for now.
Also, slightly change the spec name from "run" to
"runs" and change the last assertion, it's cleaner
to check empty error.
Thanks to David Rodríguez for this!
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/ba8eaa70c3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
With older versions of rubocop, the dependency on
`jaro_winkler` seems to be a pain.
However, in the later versions of rubocop, this
dependency was dropped. So we only need to use
the older version for ruby2.3.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/9cd87eaee3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
because rubocop configuration inheritance is
messed up and when using `--ignore-parent-exclusion`,
even though the exit status is 0, the example
still fails because of the configuration issue.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/3e20b2738c
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
The later RuboCop versions don't work with ruby2.3
so we should lock the version to what works with
ruby2.3 as we haven't dropped the support yet.
And since we're using the older version of rubocop,
also fix `Max` value of `LineLength` to 120, which
is the current standard. Without this, rubocop
will throw the line length offenses.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/46d0a800a2
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/83e330fa87
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
With this, it will be ensured that the generated
(skeleton) gem will have no offenses.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/47411262e0
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Previously, we were using the old syntax like:
`task :default => :spec`, but now this commit
uses the new Ruby 1.9 hash syntax.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/b41d0fdb56
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/730b770f8a
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/e2ee0b7de3
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
File.readlines
Using File.open without a block leaves a file reference that causes issues with file operations
commands/binstubs_spec.rb
install/gems/compact_index_spec.rb
install/gems/dependency_api_spec.rb
install/gems/standalone_spec.rb
runtime/executable_spec.rb
https://github.com/rubygems/rubygems/commit/4b9a6ca156
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
Windows skip
Added one skip for:
bundle binstubs <gem>
when the gem exists in the lockfile
when generating bundle binstub outside bundler
should abort
https://github.com/rubygems/rubygems/commit/b77b484889
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
|
|
https://github.com/rubygems/rubygems/commit/4f519638ae
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/ef2dae4222
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Currently, there is no `.rubocop.yml` shipped by default.
So when a user runs `rubocop` after creating a new gem via
`bundle gem foo`, it throws a bunch of offenses.
With the default `.rubocop.yml` present, the number of those
offenses significantly reduce by 25.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/ef2dae4222
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/e3f60d8aec
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/a73fa0760e
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/f52733f6a4
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/4d1a0c465a
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/746a4b3d74
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
errors
https://github.com/rubygems/rubygems/commit/6bac832a58
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
creation
https://github.com/rubygems/rubygems/commit/9e5f7a9099
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/2af2abe5fd
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/288f073c3c
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
consistent
* Add hints for --ci option
https://github.com/rubygems/rubygems/commit/5f779f45b0
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
https://github.com/rubygems/rubygems/commit/24f3739585
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/80571452ca
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/d8e416d89b
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
* `bundle gem` has new option to select CI provider
https://github.com/rubygems/rubygems/commit/320f3546c1
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
* `bundle gem` has new option to choose CI provider other than Travis CI
https://github.com/rubygems/rubygems/commit/afaecf16de
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/22cb599bcc
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/80260b3496e357bf96ffe6f381e29bf25b6749cb
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
These specs doesn't really need an installed bundle, they only need a
`Gemfile`.
https://github.com/rubygems/rubygems/commit/06c85683ae
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
https://github.com/rubygems/rubygems/commit/ade0c441d5
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
This spec is specifically testing for the case where there's no
`Gemfile.lock` file and it's only doing the expected thing because the
`bundle install` command is silently failing. Remove the `bundle
install` to reduce confusion.
https://github.com/rubygems/rubygems/commit/ec39fbde0e
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
They don't need to run that many commands, and the new version is also
more readable in my opinion.
https://github.com/rubygems/rubygems/commit/efff3e3210
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|
|
They are preceded by `install_gemfile` calls, which mean `bundle
install` is being run twice for no reason.
https://github.com/rubygems/rubygems/commit/d2b2d10862
Notes:
Merged: https://github.com/ruby/ruby/pull/3212
|