diff options
author | MSP-Greg <Greg.mpls@gmail.com> | 2020-06-17 21:26:13 -0500 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-07-15 16:05:12 +0900 |
commit | 23cf99e99dbae352f8497fb20cc92248c9b63580 (patch) | |
tree | d69c5dee7c126af66812b59cc3ab2d96f0c3d535 /spec/bundler/commands | |
parent | ad743337b376d8e2a9dae7350b0e89eed636c5bb (diff) |
[rubygems/rubygems] Bundler specs - Windows - remove skips, File.open => File.readlines
Using File.open without a block leaves a file reference that causes issues with file operations
commands/binstubs_spec.rb
install/gems/compact_index_spec.rb
install/gems/dependency_api_spec.rb
install/gems/standalone_spec.rb
runtime/executable_spec.rb
https://github.com/rubygems/rubygems/commit/4b9a6ca156
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/3275
Diffstat (limited to 'spec/bundler/commands')
-rw-r--r-- | spec/bundler/commands/binstubs_spec.rb | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/spec/bundler/commands/binstubs_spec.rb b/spec/bundler/commands/binstubs_spec.rb index 81e7817a3e..2af5839a24 100644 --- a/spec/bundler/commands/binstubs_spec.rb +++ b/spec/bundler/commands/binstubs_spec.rb @@ -75,7 +75,6 @@ RSpec.describe "bundle binstubs <gem>" do context "when generating bundle binstub outside bundler" do it "should abort" do - skip "Unknown issue" if Gem.win_platform? install_gemfile <<-G source "#{file_uri_for(gem_repo1)}" gem "rack" @@ -285,8 +284,7 @@ RSpec.describe "bundle binstubs <gem>" do G bundle "binstubs rack --shebang jruby" - - expect(File.open(bundled_app("bin/rackup")).gets).to eq("#!/usr/bin/env jruby\n") + expect(File.readlines(bundled_app("bin/rackup")).first).to eq("#!/usr/bin/env jruby\n") end end end |