summaryrefslogtreecommitdiff
path: root/spec/bundler/commands/doctor_spec.rb
AgeCommit message (Collapse)Author
4 days[ruby/rubygems] Allow File.writable?/File.readable? fallbacks in doctor specsHiroshi SHIBATA
doctor_spec.rb strict-stubs File.writable? and File.readable? with specific paths, which was safe as long as the doctor command did not trigger Plugin.hook. The new before-eval/after-eval hooks fire during Bundler.definition, which the doctor command calls, and Plugin.hook initializes Plugin::Index, which touches Bundler.user_home and calls File.writable? on the test home path. Those calls do not match the stubs and RSpec raises. Match the existing File.exist? pattern and add and_call_original fallbacks so unrelated paths fall through to the real methods, while the specific stubs continue to control the paths under test. https://github.com/ruby/rubygems/commit/a8c04c4536 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-23Revert "[ruby/rubygems] Move bundler/spec to top-level spec/ directory"Hiroshi SHIBATA
This reverts commit d1b8503e59dc5171580efba9f33f256b79008bc4.
2026-03-23[ruby/rubygems] Move bundler/spec to top-level spec/ directoryHiroshi SHIBATA
This simplifies running bundler tests from the repository root. Tests can now be run with `bin/rspec spec/...` instead of needing to chdir into bundler/ first. https://github.com/ruby/rubygems/commit/28670c2e20 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2025-05-12[rubygems/rubygems] Fix doctor command parsing of otool outputRandy Stauner
I have several gem dylibs that have a line matching "(compatibility " with no file path preceding it. https://github.com/rubygems/rubygems/commit/de9dc2bdc4
2025-04-22[rubygems/rubygems] Define `bundler doctor` as a subcommandEdouard CHIN
- See explanation in previous commit https://github.com/rubygems/rubygems/commit/170890befb4c https://github.com/rubygems/rubygems/commit/8f1b5a4479
2025-02-25[rubygems/rubygems] Modify `bundle doctor` to not report issue when files ↵Edouard CHIN
aren't writable: - ### Problem Running `bundle doctor` warn about files that aren't writable. This makes the output of `bundle doctor` very verbose for something I believe isn't really an issue. ### Context Rubygems keeps the files original permission at the time the gem is packaged. Many gem maintainers have decided that the permissions of the files in their bundled would be 0444, this includes amongst others: minitest, selenium, brakeman... Any git gems that had a 0444 permissions at some point in its git history would also be reported (as bundle doctor look in the `cache/bundler/git/<gem>/object` path). While it completely make sense to report when files aren't readable, maybe it's worth questioning the usefulness of reporting files that can't be written and what problem this causes to the user (if any). ### Solution Removed the check for unwritable file. ### Side note I also tweaked the "No issues ..." message logic as it was doing the opposite (reporting an issue when there is none and vice versa). This wasn't caught in tests because as a stub on `Bundler.ui.info` was missing. https://github.com/rubygems/rubygems/commit/9a426b9495 Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-13[rubygems/rubygems] Stub-out additional examples and removed needless Error ↵Hiroshi SHIBATA
definition https://github.com/rubygems/rubygems/commit/d24d0b5c43
2025-02-05Expand stub-out scope of Fiddle.dlopenHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/12616
2024-06-28Synchronize Bundler & RubyGems (#11071)David Rodríguez
2023-10-11[rubygems/rubygems] Update incorrect comments.Ellen Marie Dash
https://github.com/rubygems/rubygems/commit/6b21f593f3
2023-10-11[rubygems/rubygems] Simplify logic for Gem::PathSupport#home, and make ↵Ellen Marie Dash
GEM_HOME always overide it. https://github.com/rubygems/rubygems/commit/64273fd7e3
2023-10-11[rubygems/rubygems] Split out Gem::PathSupport#default_home_dir to fix ↵Ellen Marie Dash
"bundle doctor" specs. https://github.com/rubygems/rubygems/commit/d7f3f901f1
2023-07-24[rubygems/rubygems] Prefer squiggly heredocs over custom helperDavid Rodríguez
https://github.com/rubygems/rubygems/commit/258476c38a
2023-01-10Merge RubyGems and Bundler masterHiroshi SHIBATA
from https://github.com/rubygems/rubygems/commit/0635c1423db5d7c461d53bf0c3329bca75de7609 Notes: Merged: https://github.com/ruby/ruby/pull/7094
2022-01-13[rubygems/rubygems] Use `Fiddle` in `bundle doctor` to check for dynamic ↵Vyacheslav Alexeev
library presence https://github.com/rubygems/rubygems/commit/ecd495ce1b
2021-11-30[rubygems/rubygems] Fix escape of filenames in `bundle doctor`ooooooo-q
https://github.com/rubygems/rubygems/commit/3ede1435ea
2021-11-25[rubygems/rubygems] Fix bad instance variable nameDavid Rodríguez
Recent changes made a warning while running specs show up for some reason, and it revealed this error. https://github.com/rubygems/rubygems/commit/bbf55de38e
2021-07-07Sync RubyGems and Bundler with upstreamHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/4634
2020-07-15[rubygems/rubygems] Remove unnecessary assertions on exitstatusDavid Rodríguez
Since our helpers now raise by default if the subcommand fails, these will never actually fail and are not necessary. https://github.com/rubygems/rubygems/commit/6153b9321e Notes: Merged: https://github.com/ruby/ruby/pull/3275
2020-06-18[rubygems/rubygems] s/install_gemfile!/install_gemfileDavid Rodríguez
https://github.com/rubygems/rubygems/commit/4d1a0c465a Notes: Merged: https://github.com/ruby/ruby/pull/3212
2020-05-13Update the bundler version with master branchHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/3086
2019-08-18[bundler/bundler] Fix `bundle doctor` commandDavid Rodríguez
Previously `bundle doctor` would fail on any bundle that does not include git gems or plugins. This is because the previously used `Bundler.home` does not exist unless the bundle includes git gems or plugins. For example, with `bundle config set path .bundle`, it points to which does not exist unless this kind of gems exist in the Gemfile. The name `Bundler.home` is really unfortunate, it should probably be have more descriptive name, and be private. But for now I just want to make `bundle doctor` usable. https://github.com/bundler/bundler/commit/5531a18c1e
2019-08-03[bundler/bundler] Normalize file:// handling in specsDavid Rodríguez
https://github.com/bundler/bundler/commit/5946d62ad0
2018-11-02Added bundler as default gems. Revisit [Feature #12733]hsbt
* bin/*, lib/bundler/*, lib/bundler.rb, spec/bundler, man/*: Merge from latest stable branch of bundler/bundler repository and added workaround patches. I will backport them into upstream. * common.mk, defs/gmake.mk: Added `test-bundler` task for test suite of bundler. * tool/sync_default_gems.rb: Added sync task for bundler. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65509 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-12-22Postponing the Bundler merge.hsbt
I faced a big issue about Bundler with ruby core. I have no time to resolve it issue before 2.5 final release. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61416 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-11-01Update bundled bundler to 1.16.0.hsbt
* lib/bundler, spec/bundler: Merge bundler-1.16.0. * common.mk: rspec examples of bundler-1.16.0 needs require option. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60603 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2017-09-08Merge bundler to standard libraries.hsbt
rubygems 2.7.x depends bundler-1.15.x. This is preparation for rubygems and bundler migration. * lib/bundler.rb, lib/bundler/*: files of bundler-1.15.4 * spec/bundler/*: rspec examples of bundler-1.15.4. I applied patches. * https://github.com/bundler/bundler/pull/6007 * Exclude not working examples on ruby repository. * Fake ruby interpriter instead of installed ruby. * Makefile.in: Added test task named `test-bundler`. This task is only working macOS/linux yet. I'm going to support Windows environment later. * tool/sync_default_gems.rb: Added sync task for bundler. [Feature #12733][ruby-core:77172] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
generated by cgit v1.2.3 (git 2.25.1) at 2026-05-17 17:18:42 +0000