1 files changed, 34 insertions, 80 deletions
diff --git a/spec/ruby/core/string/to_c_spec.rb b/spec/ruby/core/string/to_c_spec.rb
index 9c84b14f4d..9d24f1f56c 100644
--- a/spec/ruby/core/string/to_c_spec.rb
+++ b/spec/ruby/core/string/to_c_spec.rb
@@ -1,99 +1,53 @@
 require_relative '../../spec_helper'
+require_relative '../../shared/kernel/complex'
+require_relative 'fixtures/to_c'
 
 describe "String#to_c" do
-  it "returns a Complex object" do
-    '9'.to_c.should be_an_instance_of(Complex)
-  end
-
-  it "understands integers" do
-    '20'.to_c.should == Complex(20)
-  end
-
-  it "understands negative integers" do
-    '-3'.to_c.should == Complex(-3)
-  end
-
-  it "understands fractions (numerator/denominator) for the real part" do
-    '2/3'.to_c.should == Complex(Rational(2, 3))
-  end
-
-  it "understands fractions (numerator/denominator) for the imaginary part" do
-    '4+2/3i'.to_c.should == Complex(4, Rational(2, 3))
-  end
-
-  it "understands negative fractions (-numerator/denominator) for the real part" do
-    '-2/3'.to_c.should == Complex(Rational(-2, 3))
-  end
-
-  it "understands negative fractions (-numerator/denominator) for the imaginary part" do
-    '7-2/3i'.to_c.should == Complex(7, Rational(-2, 3))
-  end
-
-  it "understands floats (a.b) for the real part" do
-    '2.3'.to_c.should == Complex(2.3)
-  end
-
-  it "understands floats (a.b) for the imaginary part" do
-    '4+2.3i'.to_c.should == Complex(4, 2.3)
-  end
-
-  it "understands negative floats (-a.b) for the real part" do
-    '-2.33'.to_c.should == Complex(-2.33)
-  end
-
-  it "understands negative floats (-a.b) for the imaginary part" do
-    '7-28.771i'.to_c.should == Complex(7, -28.771)
-  end
-
-  it "understands an integer followed by 'i' to mean that integer is the imaginary part" do
-    '35i'.to_c.should == Complex(0,35)
-  end
-
-  it "understands a negative integer followed by 'i' to mean that negative integer is the imaginary part" do
-    '-29i'.to_c.should == Complex(0,-29)
-  end
-
-  it "understands an 'i' by itself as denoting a complex number with an imaginary part of 1" do
-    'i'.to_c.should == Complex(0,1)
-  end
-
-  it "understands a '-i' by itself as denoting a complex number with an imaginary part of -1" do
-    '-i'.to_c.should == Complex(0,-1)
-  end
-
-  it "understands 'a+bi' to mean a complex number with 'a' as the real part, 'b' as the imaginary" do
-    '79+4i'.to_c.should == Complex(79,4)
-  end
+  it_behaves_like :kernel_complex, :to_c_method, StringSpecs
+end
 
-  it "understands 'a-bi' to mean a complex number with 'a' as the real part, '-b' as the imaginary" do
-    '79-4i'.to_c.should == Complex(79,-4)
+describe "String#to_c" do
+  it "returns a complex number with 0 as the real part, 0 as the imaginary part for unrecognised Strings" do
+    'ruby'.to_c.should == Complex(0, 0)
   end
 
-  it "understands scientific notation for the real part" do
-    '2e3+4i'.to_c.should == Complex(2e3,4)
+  it "ignores trailing garbage" do
+    '79+4iruby'.to_c.should == Complex(79, 4)
+    ruby_bug "[Bug #19087]", ""..."3.2" do
+      '7__9+4__0i'.to_c.should == Complex(7, 0)
+    end
   end
 
-  it "understands negative scientific notation for the real part" do
-    '-2e3+4i'.to_c.should == Complex(-2e3,4)
+  it "understands Float::INFINITY" do
+    'Infinity'.to_c.should == Complex(0, 1)
+    '-Infinity'.to_c.should == Complex(0, -1)
   end
 
-  it "understands scientific notation for the imaginary part" do
-    '4+2e3i'.to_c.should == Complex(4, 2e3)
+  it "understands Float::NAN" do
+    'NaN'.to_c.should == Complex(0, 0)
   end
 
-  it "understands negative scientific notation for the imaginary part" do
-    '4-2e3i'.to_c.should == Complex(4, -2e3)
+  it "allows null-byte" do
+    "1-2i\0".to_c.should == Complex(1, -2)
+    "1\0-2i".to_c.should == Complex(1, 0)
+    "\01-2i".to_c.should == Complex(0, 0)
   end
 
-  it "understands scientific notation for the real and imaginary part in the same String" do
-    '2e3+2e4i'.to_c.should == Complex(2e3,2e4)
+  it "raises Encoding::CompatibilityError if String is in not ASCII-compatible encoding" do
+    -> {
+      '79+4i'.encode("UTF-16").to_c
+    }.should raise_error(Encoding::CompatibilityError, "ASCII incompatible encoding: UTF-16")
   end
 
-  it "understands negative scientific notation for the real and imaginary part in the same String" do
-    '-2e3-2e4i'.to_c.should == Complex(-2e3,-2e4)
-  end
+  ruby_version_is "3.2" do
+    it "treats a sequence of underscores as an end of Complex string" do
+      "5+3_1i".to_c.should == Complex(5, 31)
+      "5+3__1i".to_c.should == Complex(5)
+      "5+3___1i".to_c.should == Complex(5)
 
-  it "returns a complex number with 0 as the real part, 0 as the imaginary part for unrecognised Strings" do
-  'ruby'.to_c.should == Complex(0,0)
+      "12_3".to_c.should == Complex(123)
+      "12__3".to_c.should == Complex(12)
+      "12___3".to_c.should == Complex(12)
+    end
   end
 end