diff options
Diffstat (limited to 'spec/ruby/core/signal')
| -rw-r--r-- | spec/ruby/core/signal/fixtures/trap_all.rb | 15 | ||||
| -rw-r--r-- | spec/ruby/core/signal/list_spec.rb | 6 | ||||
| -rw-r--r-- | spec/ruby/core/signal/signame_spec.rb | 31 | ||||
| -rw-r--r-- | spec/ruby/core/signal/trap_spec.rb | 265 |
4 files changed, 266 insertions, 51 deletions
diff --git a/spec/ruby/core/signal/fixtures/trap_all.rb b/spec/ruby/core/signal/fixtures/trap_all.rb new file mode 100644 index 0000000000..afa00b498d --- /dev/null +++ b/spec/ruby/core/signal/fixtures/trap_all.rb @@ -0,0 +1,15 @@ +cannot_be_trapped = %w[KILL STOP] # See man 2 signal + +(Signal.list.keys - cannot_be_trapped).each do |signal| + begin + Signal.trap(signal, -> {}) + rescue ArgumentError => e + unless /can't trap reserved signal|Signal already used by VM or OS/ =~ e.message + raise e + end + else + Signal.trap(signal, "DEFAULT") + end +end + +puts "OK" diff --git a/spec/ruby/core/signal/list_spec.rb b/spec/ruby/core/signal/list_spec.rb index 510b671337..56ad6828fe 100644 --- a/spec/ruby/core/signal/list_spec.rb +++ b/spec/ruby/core/signal/list_spec.rb @@ -1,4 +1,4 @@ -require File.expand_path('../../../spec_helper', __FILE__) +require_relative '../../spec_helper' describe "Signal.list" do RUBY_SIGNALS = %w{ @@ -61,4 +61,8 @@ describe "Signal.list" do it "includes the EXIT key with a value of zero" do Signal.list["EXIT"].should == 0 end + + it "includes the KILL key with a value of nine" do + Signal.list["KILL"].should == 9 + end end diff --git a/spec/ruby/core/signal/signame_spec.rb b/spec/ruby/core/signal/signame_spec.rb index 1874a67933..82f040a6f9 100644 --- a/spec/ruby/core/signal/signame_spec.rb +++ b/spec/ruby/core/signal/signame_spec.rb @@ -1,23 +1,34 @@ -require File.expand_path('../../../spec_helper', __FILE__) +require_relative '../../spec_helper' describe "Signal.signame" do it "takes a signal name with a well known signal number" do Signal.signame(0).should == "EXIT" end - ruby_version_is "2.0"..."2.3" do - it "raises an ArgumentError if the argument is an invalid signal number" do - lambda { Signal.signame(-1) }.should raise_error(ArgumentError) - end + it "returns nil if the argument is an invalid signal number" do + Signal.signame(-1).should == nil end - ruby_version_is "2.3" do - it "returns nil if the argument is an invalid signal number" do - Signal.signame(-1).should == nil - end + it "calls #to_int on an object to convert to an Integer" do + obj = mock('signal') + obj.should_receive(:to_int).and_return(0) + Signal.signame(obj).should == "EXIT" end it "raises a TypeError when the passed argument can't be coerced to Integer" do - lambda { Signal.signame("hello") }.should raise_error(TypeError) + -> { Signal.signame("hello") }.should.raise(TypeError) + end + + it "raises a TypeError when the passed argument responds to #to_int but does not return an Integer" do + obj = mock('signal') + obj.should_receive(:to_int).and_return('not an int') + -> { Signal.signame(obj) }.should.raise(TypeError) + end + + platform_is_not :windows do + it "the original should take precedence over alias when looked up by number" do + Signal.signame(Signal.list["ABRT"]).should == "ABRT" + Signal.signame(Signal.list["CHLD"]).should == "CHLD" + end end end diff --git a/spec/ruby/core/signal/trap_spec.rb b/spec/ruby/core/signal/trap_spec.rb index 787de1735c..5d3105fee8 100644 --- a/spec/ruby/core/signal/trap_spec.rb +++ b/spec/ruby/core/signal/trap_spec.rb @@ -1,12 +1,12 @@ -require File.expand_path('../../../spec_helper', __FILE__) +require_relative '../../spec_helper' -platform_is_not :windows do - describe "Signal.trap" do +describe "Signal.trap" do + platform_is_not :windows do before :each do ScratchPad.clear - - @proc = lambda { ScratchPad.record :proc_trap } + @proc = -> {} @saved_trap = Signal.trap(:HUP, @proc) + @hup_number = Signal.list["HUP"] end after :each do @@ -14,13 +14,14 @@ platform_is_not :windows do end it "returns the previous handler" do - Signal.trap(:HUP, @saved_trap).should equal(@proc) + Signal.trap(:HUP, @saved_trap).should.equal?(@proc) end - it "accepts a block in place of a proc/command argument" do + it "accepts a block" do done = false - Signal.trap(:HUP) do + Signal.trap(:HUP) do |signo| + signo.should == @hup_number ScratchPad.record :block_trap done = true end @@ -31,6 +32,94 @@ platform_is_not :windows do ScratchPad.recorded.should == :block_trap end + it "accepts a proc" do + done = false + + handler = -> signo { + signo.should == @hup_number + ScratchPad.record :proc_trap + done = true + } + + Signal.trap(:HUP, handler) + + Process.kill :HUP, Process.pid + Thread.pass until done + + ScratchPad.recorded.should == :proc_trap + end + + it "accepts a method" do + done = false + + handler_class = Class.new + hup_number = @hup_number + + handler_class.define_method :handler_method do |signo| + signo.should == hup_number + ScratchPad.record :method_trap + done = true + end + + handler_method = handler_class.new.method(:handler_method) + + Signal.trap(:HUP, handler_method) + + Process.kill :HUP, Process.pid + Thread.pass until done + + ScratchPad.recorded.should == :method_trap + end + + it "accepts anything you can call" do + done = false + + callable = Object.new + hup_number = @hup_number + + callable.singleton_class.define_method :call do |signo| + signo.should == hup_number + ScratchPad.record :callable_trap + done = true + end + + Signal.trap(:HUP, callable) + + Process.kill :HUP, Process.pid + Thread.pass until done + + ScratchPad.recorded.should == :callable_trap + end + + it "raises an exception for a non-callable at the point of use" do + not_callable = Object.new + Signal.trap(:HUP, not_callable) + -> { + Process.kill :HUP, Process.pid + loop { Thread.pass } + }.should.raise(NoMethodError) + end + + it "accepts a non-callable that becomes callable when used" do + done = false + + late_callable = Object.new + hup_number = @hup_number + + Signal.trap(:HUP, late_callable) + + late_callable.singleton_class.define_method :call do |signo| + signo.should == hup_number + ScratchPad.record :late_callable_trap + done = true + end + + Process.kill :HUP, Process.pid + Thread.pass until done + + ScratchPad.recorded.should == :late_callable_trap + end + it "is possible to create a new Thread when the handler runs" do done = false @@ -45,91 +134,187 @@ platform_is_not :windows do Process.kill :HUP, Process.pid Thread.pass until done - ScratchPad.recorded.should be_true + ScratchPad.recorded.should == true + end + + it "registers an handler doing nothing with :IGNORE" do + Signal.trap :HUP, :IGNORE + Signal.trap(:HUP, @saved_trap).should == "IGNORE" + end + + it "can register a new handler after :IGNORE" do + Signal.trap :HUP, :IGNORE + + done = false + Signal.trap(:HUP) do + ScratchPad.record :block_trap + done = true + end + + Process.kill(:HUP, Process.pid).should == 1 + Thread.pass until done + ScratchPad.recorded.should == :block_trap end it "ignores the signal when passed nil" do Signal.trap :HUP, nil - Signal.trap(:HUP, @saved_trap).should be_nil + Signal.trap(:HUP, @saved_trap).should == nil end - it "accepts 'DEFAULT' as a symbol in place of a proc" do + it "accepts :DEFAULT in place of a proc" do Signal.trap :HUP, :DEFAULT - Signal.trap(:HUP, :DEFAULT).should == "DEFAULT" + Signal.trap(:HUP, @saved_trap).should == "DEFAULT" end - it "accepts 'SIG_DFL' as a symbol in place of a proc" do + it "accepts :SIG_DFL in place of a proc" do Signal.trap :HUP, :SIG_DFL - Signal.trap(:HUP, :SIG_DFL).should == "DEFAULT" + Signal.trap(:HUP, @saved_trap).should == "DEFAULT" end - it "accepts 'SIG_IGN' as a symbol in place of a proc" do + it "accepts :SIG_IGN in place of a proc" do Signal.trap :HUP, :SIG_IGN - Signal.trap(:HUP, :SIG_IGN).should == "IGNORE" + Signal.trap(:HUP, @saved_trap).should == "IGNORE" end - it "accepts 'IGNORE' as a symbol in place of a proc" do + it "accepts :IGNORE in place of a proc" do Signal.trap :HUP, :IGNORE - Signal.trap(:HUP, :IGNORE).should == "IGNORE" + Signal.trap(:HUP, @saved_trap).should == "IGNORE" + end + + it "accepts 'SIG_DFL' in place of a proc" do + Signal.trap :HUP, "SIG_DFL" + Signal.trap(:HUP, @saved_trap).should == "DEFAULT" + end + + it "accepts 'DEFAULT' in place of a proc" do + Signal.trap :HUP, "DEFAULT" + Signal.trap(:HUP, @saved_trap).should == "DEFAULT" + end + + it "accepts 'SIG_IGN' in place of a proc" do + Signal.trap :HUP, "SIG_IGN" + Signal.trap(:HUP, @saved_trap).should == "IGNORE" + end + + it "accepts 'IGNORE' in place of a proc" do + Signal.trap :HUP, "IGNORE" + Signal.trap(:HUP, @saved_trap).should == "IGNORE" end it "accepts long names as Strings" do Signal.trap "SIGHUP", @proc - Signal.trap("SIGHUP", @saved_trap).should equal(@proc) + Signal.trap("SIGHUP", @saved_trap).should.equal?(@proc) end - it "acceps short names as Strings" do + it "accepts short names as Strings" do Signal.trap "HUP", @proc - Signal.trap("HUP", @saved_trap).should equal(@proc) + Signal.trap("HUP", @saved_trap).should.equal?(@proc) end it "accepts long names as Symbols" do Signal.trap :SIGHUP, @proc - Signal.trap(:SIGHUP, @saved_trap).should equal(@proc) + Signal.trap(:SIGHUP, @saved_trap).should.equal?(@proc) end it "accepts short names as Symbols" do Signal.trap :HUP, @proc - Signal.trap(:HUP, @saved_trap).should equal(@proc) + Signal.trap(:HUP, @saved_trap).should.equal?(@proc) end - it "accepts 'SIG_DFL' in place of a proc" do - Signal.trap :HUP, "SIG_DFL" - Signal.trap(:HUP, @saved_trap).should == "DEFAULT" + it "calls #to_str on an object to convert to a String" do + obj = mock("signal") + obj.should_receive(:to_str).exactly(2).times.and_return("HUP") + Signal.trap obj, @proc + Signal.trap(obj, @saved_trap).should.equal?(@proc) end - it "accepts 'DEFAULT' in place of a proc" do - Signal.trap :HUP, "DEFAULT" - Signal.trap(:HUP, @saved_trap).should == "DEFAULT" + it "accepts Integer values" do + hup = Signal.list["HUP"] + Signal.trap hup, @proc + Signal.trap(hup, @saved_trap).should.equal?(@proc) end - it "accepts 'SIG_IGN' in place of a proc" do - Signal.trap :HUP, "SIG_IGN" - Signal.trap(:HUP, "SIG_IGN").should == "IGNORE" + it "does not call #to_int on an object to convert to an Integer" do + obj = mock("signal") + obj.should_not_receive(:to_int) + -> { Signal.trap obj, @proc }.should.raise(ArgumentError, /bad signal type/) end - it "accepts 'IGNORE' in place of a proc" do - Signal.trap :HUP, "IGNORE" - Signal.trap(:HUP, "IGNORE").should == "IGNORE" + it "raises ArgumentError when passed unknown signal" do + -> { Signal.trap(300) { } }.should.raise(ArgumentError, "invalid signal number (300)") + -> { Signal.trap("USR10") { } }.should.raise(ArgumentError, /\Aunsupported signal [`']SIGUSR10'\z/) + -> { Signal.trap("SIGUSR10") { } }.should.raise(ArgumentError, /\Aunsupported signal [`']SIGUSR10'\z/) + end + + it "raises ArgumentError when passed signal is not Integer, String or Symbol" do + -> { Signal.trap(nil) { } }.should.raise(ArgumentError, "bad signal type NilClass") + -> { Signal.trap(100.0) { } }.should.raise(ArgumentError, "bad signal type Float") + -> { Signal.trap(Rational(100)) { } }.should.raise(ArgumentError, "bad signal type Rational") + end + + # See man 2 signal + %w[KILL STOP].each do |signal| + it "raises ArgumentError or Errno::EINVAL for SIG#{signal}" do + -> { + Signal.trap(signal, -> {}) + }.should.raise(StandardError) { |e| + [ArgumentError, Errno::EINVAL].should.include?(e.class) + e.message.should =~ /Invalid argument|Signal already used by VM or OS/ + } + end + end + + %w[SEGV BUS ILL FPE VTALRM].each do |signal| + it "raises ArgumentError for SIG#{signal} which is reserved by Ruby" do + -> { + Signal.trap(signal, -> {}) + }.should.raise(ArgumentError, "can't trap reserved signal: SIG#{signal}") + end + end + + it "allows to register a handler for all known signals, except reserved signals for which it raises ArgumentError" do + out = ruby_exe(fixture(__FILE__, "trap_all.rb"), args: "2>&1") + out.should == "OK\n" + $?.exitstatus.should == 0 + end + + it "returns 'DEFAULT' for the initial SIGINT handler" do + ruby_exe("print Signal.trap(:INT) { abort }").should == 'DEFAULT' + end + + it "returns SYSTEM_DEFAULT if passed DEFAULT and no handler was ever set" do + Signal.trap("PROF", "DEFAULT").should == "SYSTEM_DEFAULT" + end + + it "accepts 'SYSTEM_DEFAULT' and uses the OS handler for SIGPIPE" do + code = <<-RUBY + p Signal.trap('PIPE', 'SYSTEM_DEFAULT') + r, w = IO.pipe + r.close + loop { w.write("a"*1024) } + RUBY + out = ruby_exe(code, exit_status: :SIGPIPE) + status = $? + out.should == "nil\n" + status.should.signaled? end end -end -describe "Signal.trap" do describe "the special EXIT signal code" do it "accepts the EXIT code" do - code = "trap(:EXIT, proc { print 1 })" + code = "Signal.trap(:EXIT, proc { print 1 })" ruby_exe(code).should == "1" end it "runs the proc before at_exit handlers" do - code = "at_exit {print 1}; trap(:EXIT, proc {print 2}); at_exit {print 3}" + code = "at_exit {print 1}; Signal.trap(:EXIT, proc {print 2}); at_exit {print 3}" ruby_exe(code).should == "231" end it "can unset the handler" do - code = "trap(:EXIT, proc { print 1 }); trap(:EXIT, 'DEFAULT')" + code = "Signal.trap(:EXIT, proc { print 1 }); Signal.trap(:EXIT, 'DEFAULT')" ruby_exe(code).should == "" end end + end |
