1 files changed, 119 insertions, 17 deletions
diff --git a/spec/ruby/core/matchdata/begin_spec.rb b/spec/ruby/core/matchdata/begin_spec.rb
index b791018633..b4be077ae4 100644
--- a/spec/ruby/core/matchdata/begin_spec.rb
+++ b/spec/ruby/core/matchdata/begin_spec.rb
@@ -3,28 +3,130 @@
 require_relative '../../spec_helper'
 
 describe "MatchData#begin" do
-  it "returns the offset of the start of the nth element" do
-    match_data = /(.)(.)(\d+)(\d)/.match("THX1138.")
-    match_data.begin(0).should == 1
-    match_data.begin(2).should == 2
-  end
+  context "when passed an integer argument" do
+    it "returns the character offset of the start of the nth element" do
+      match_data = /(.)(.)(\d+)(\d)/.match("THX1138.")
+      match_data.begin(0).should == 1
+      match_data.begin(2).should == 2
+    end
+
+    it "returns nil when the nth match isn't found" do
+      match_data = /something is( not)? (right)/.match("something is right")
+      match_data.begin(1).should == nil
+    end
+
+    it "returns the character offset for multi-byte strings" do
+      match_data = /(.)(.)(\d+)(\d)/.match("TñX1138.")
+      match_data.begin(0).should == 1
+      match_data.begin(2).should == 2
+    end
+
+    not_supported_on :opal do
+      it "returns the character offset for multi-byte strings with unicode regexp" do
+        match_data = /(.)(.)(\d+)(\d)/u.match("TñX1138.")
+        match_data.begin(0).should == 1
+        match_data.begin(2).should == 2
+      end
+    end
+
+    it "tries to convert the passed argument to an Integer using #to_int" do
+      obj = mock('to_int')
+      obj.should_receive(:to_int).and_return(2)
+
+      match_data = /(.)(.)(\d+)(\d)/.match("THX1138.")
+      match_data.begin(obj).should == 2
+    end
+
+    it "raises IndexError if index is out of bounds" do
+      match_data = /(?<f>foo)(?<b>bar)/.match("foobar")
+
+      -> {
+        match_data.begin(-1)
+      }.should.raise(IndexError, "index -1 out of matches")
 
-  it "returns nil when the nth match isn't found" do
-    match_data = /something is( not)? (right)/.match("something is right")
-    match_data.begin(1).should be_nil
+      -> {
+        match_data.begin(3)
+      }.should.raise(IndexError, "index 3 out of matches")
+    end
   end
 
-  it "returns the offset for multi byte strings" do
-    match_data = /(.)(.)(\d+)(\d)/.match("TñX1138.")
-    match_data.begin(0).should == 1
-    match_data.begin(2).should == 2
+  context "when passed a String argument" do
+    it "return the character offset of the start of the named capture" do
+      match_data = /(?<a>.)(.)(?<b>\d+)(\d)/.match("THX1138.")
+      match_data.begin("a").should == 1
+      match_data.begin("b").should == 3
+    end
+
+    it "returns the character offset for multi byte strings" do
+      match_data = /(?<a>.)(.)(?<b>\d+)(\d)/.match("TñX1138.")
+      match_data.begin("a").should == 1
+      match_data.begin("b").should == 3
+    end
+
+    not_supported_on :opal do
+      it "returns the character offset for multi byte strings with unicode regexp" do
+        match_data = /(?<a>.)(.)(?<b>\d+)(\d)/u.match("TñX1138.")
+        match_data.begin("a").should == 1
+        match_data.begin("b").should == 3
+      end
+    end
+
+    it "returns the character offset for the farthest match when multiple named captures use the same name" do
+      match_data = /(?<a>.)(.)(?<a>\d+)(\d)/.match("THX1138.")
+      match_data.begin("a").should == 3
+    end
+
+    it "returns the character offset for multi-byte names" do
+      match_data = /(?<æ>.)(.)(?<b>\d+)(\d)/.match("THX1138.")
+      match_data.begin("æ").should == 1
+    end
+
+    it "raises IndexError if there is no group with the provided name" do
+      match_data = /(?<f>foo)(?<b>bar)/.match("foobar")
+
+      -> {
+        match_data.begin("y")
+      }.should.raise(IndexError, "undefined group name reference: y")
+    end
   end
 
-  not_supported_on :opal do
-    it "returns the offset for multi byte strings with unicode regexp" do
-      match_data = /(.)(.)(\d+)(\d)/u.match("TñX1138.")
-      match_data.begin(0).should == 1
-      match_data.begin(2).should == 2
+  context "when passed a Symbol argument" do
+    it "return the character offset of the start of the named capture" do
+      match_data = /(?<a>.)(.)(?<b>\d+)(\d)/.match("THX1138.")
+      match_data.begin(:a).should == 1
+      match_data.begin(:b).should == 3
+    end
+
+    it "returns the character offset for multi byte strings" do
+      match_data = /(?<a>.)(.)(?<b>\d+)(\d)/.match("TñX1138.")
+      match_data.begin(:a).should == 1
+      match_data.begin(:b).should == 3
+    end
+
+    not_supported_on :opal do
+      it "returns the character offset for multi byte strings with unicode regexp" do
+        match_data = /(?<a>.)(.)(?<b>\d+)(\d)/u.match("TñX1138.")
+        match_data.begin(:a).should == 1
+        match_data.begin(:b).should == 3
+      end
+    end
+
+    it "returns the character offset for the farthest match when multiple named captures use the same name" do
+      match_data = /(?<a>.)(.)(?<a>\d+)(\d)/.match("THX1138.")
+      match_data.begin(:a).should == 3
+    end
+
+    it "returns the character offset for multi-byte names" do
+      match_data = /(?<æ>.)(.)(?<b>\d+)(\d)/.match("THX1138.")
+      match_data.begin(:æ).should == 1
+    end
+
+    it "raises IndexError if there is no group with the provided name" do
+      match_data = /(?<f>foo)(?<b>bar)/.match("foobar")
+
+      -> {
+        match_data.begin(:y)
+      }.should.raise(IndexError, "undefined group name reference: y")
     end
   end
 end