diff options
| author | Alan Wu <XrXr@users.noreply.github.com> | 2026-05-07 11:21:59 -0400 |
|---|---|---|
| committer | Alan Wu <XrXr@users.noreply.github.com> | 2026-05-07 16:04:56 -0400 |
| commit | c133f51e3d9f9a3d0d3aa94b4eff1c42da78b7be (patch) | |
| tree | b285640c430f6c1b6f5418a733c3f7d9e2dd30e1 /zjit | |
| parent | b6e4fa71d514796ee826b1257bfd7b2a177f5f09 (diff) | |
ZJIT: Remove from `Invariants` on invalidation
Previously, we kept around `PatchPoint`s after patching them for several
kinds of invariants. That wasted compute since repeated invalidation
with the same key patched a growing list of patchpoints each time,
making it accidentally O(n^2). Retaining the patchpoints also used memory.
Some invariants, such as rb_zjit_invalidate_no_singleton_class() and
rb_zjit_invalidate_root_box(), already remove from the table. This commit
makes all invariants remove from the table.
Diffstat (limited to 'zjit')
| -rw-r--r-- | zjit/src/invariants.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/zjit/src/invariants.rs b/zjit/src/invariants.rs index 0fbeabab64..0fa800755d 100644 --- a/zjit/src/invariants.rs +++ b/zjit/src/invariants.rs @@ -188,7 +188,7 @@ pub extern "C" fn rb_zjit_bop_redefined(klass: RedefinitionFlag, bop: ruby_basic with_vm_lock(src_loc!(), || { let invariants = ZJITState::get_invariants(); - if let Some(patch_points) = invariants.bop_patch_points.get(&(klass, bop)) { + if let Some(patch_points) = invariants.bop_patch_points.remove(&(klass, bop)) { let cb = ZJITState::get_code_block(); let bop = Invariant::BOPRedefined { klass, bop }; debug!("BOP is redefined: {}", bop); @@ -372,7 +372,7 @@ pub extern "C" fn rb_zjit_constant_state_changed(id: ID) { with_vm_lock(src_loc!(), || { let invariants = ZJITState::get_invariants(); - if let Some(patch_points) = invariants.constant_state_patch_points.get(&id) { + if let Some(patch_points) = invariants.constant_state_patch_points.remove(&id) { let cb = ZJITState::get_code_block(); debug!("Constant state changed: {:?}", id); |