diff options
author | Daniel Niknam <mhmd.niknam@gmail.com> | 2021-08-24 01:01:11 +1000 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2021-08-31 19:06:14 +0900 |
commit | ceba8668642ae9567c0952724217073462fee9a8 (patch) | |
tree | 81c00ab7de787e1ea267f31a329190003cbcbf46 /test/rubygems/test_gem_printable_uri.rb | |
parent | 1948ac20ce5b1a84b8443d3b7438b18c6f2c89e9 (diff) |
[rubygems/rubygems] Remove unnecessary tests
We will be passing string to this class so there is no need to be defensive about it.
https://github.com/rubygems/rubygems/commit/30bd52a977
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/4789
Diffstat (limited to 'test/rubygems/test_gem_printable_uri.rb')
-rw-r--r-- | test/rubygems/test_gem_printable_uri.rb | 36 |
1 files changed, 0 insertions, 36 deletions
diff --git a/test/rubygems/test_gem_printable_uri.rb b/test/rubygems/test_gem_printable_uri.rb index 9f49d6538c..6d4be6efc2 100644 --- a/test/rubygems/test_gem_printable_uri.rb +++ b/test/rubygems/test_gem_printable_uri.rb @@ -1,5 +1,4 @@ require_relative 'helper' -require 'uri' require 'rubygems/printable_uri' class TestPrintableUri < Gem::TestCase @@ -7,18 +6,6 @@ class TestPrintableUri < Gem::TestCase assert_equal true, Gem::PrintableUri.parse_uri("https://www.example.com").valid_uri? end - def test_valid_uri_with_empty_uri_object - assert_equal true, Gem::PrintableUri.parse_uri(URI("")).valid_uri? - end - - def test_valid_uri_with_valid_uri_object - assert_equal true, Gem::PrintableUri.parse_uri(URI("https://www.example.com")).valid_uri? - end - - def test_valid_uri_with_other_objects - assert_equal false, Gem::PrintableUri.parse_uri(Object.new).valid_uri? - end - def test_valid_uri_with_invalid_uri assert_equal false, Gem::PrintableUri.parse_uri("https://www.example.com:80index").valid_uri? end @@ -35,14 +22,6 @@ class TestPrintableUri < Gem::TestCase assert_equal nil, Gem::PrintableUri.parse_uri("https://www.example.com").original_password end - def test_original_password_with_empty_uri_object - assert_equal nil, Gem::PrintableUri.parse_uri(URI("")).original_password - end - - def test_original_password_with_valid_uri_object - assert_equal "pass", Gem::PrintableUri.parse_uri(URI("https://user:pass@example.com")).original_password - end - def test_to_s_with_user_pass assert_equal "https://user:REDACTED@example.com", Gem::PrintableUri.parse_uri("https://user:pass@example.com").to_s end @@ -62,19 +41,4 @@ class TestPrintableUri < Gem::TestCase def test_to_s_with_invalid_uri assert_equal "https://www.example.com:80index", Gem::PrintableUri.parse_uri("https://www.example.com:80index").to_s end - - def test_to_s_with_empty_uri_object - assert_equal "", Gem::PrintableUri.parse_uri(URI("")).to_s - end - - def test_to_s_with_valid_uri_object - assert_equal "https://user:REDACTED@example.com", Gem::PrintableUri.parse_uri(URI("https://user:pass@example.com")).to_s - end - - def test_to_s_with_other_objects - obj = Object.new - obj.stub(:to_s, "my-to-s") do - assert_equal "my-to-s", Gem::PrintableUri.parse_uri(obj).to_s - end - end end |