diff options
| author | NARUSE, Yui <nurse@users.noreply.github.com> | 2024-03-21 14:31:36 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-21 05:31:36 +0000 |
| commit | f79b1d1ef1f7aa64d20f0eadbb3b0f8f7084deb3 (patch) | |
| tree | 9e7a3db4bad45e170e273e71de4766a696fca8c6 /test/ruby | |
| parent | 57a0afe2090b8d05673d650b1e8bf9ae67449b1f (diff) | |
merge revision(s) e626da82eae3d437b84d4f9ead0164d436b08e1a,f3af5ae7e6c1c096bbfe46d69de825a02b1696cf: [Backport #20311] (#10312)
Don't pin named structs defined in Ruby
[Bug #20311]
`rb_define_class_under` assumes it's called from C and that the
reference might be held in a C global variable, so it adds the
class to the VM root.
In the case of `Struct.new('Name')` it's wasteful and make
the struct immortal.
Make Struct memory leak test faster
[Bug #20311]
It times out on some platform, so we can reduce iterations.
On my machine it completes in 250ms and RSS grows 8X.
Diffstat (limited to 'test/ruby')
| -rw-r--r-- | test/ruby/test_struct.rb | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/test/ruby/test_struct.rb b/test/ruby/test_struct.rb index ed750b91f7..3d727adf04 100644 --- a/test/ruby/test_struct.rb +++ b/test/ruby/test_struct.rb @@ -534,6 +534,20 @@ module TestStruct assert_equal [[:req, :_]], klass.instance_method(:c=).parameters end + def test_named_structs_are_not_rooted + # [Bug #20311] + assert_no_memory_leak([], <<~PREP, <<~CODE, rss: true) + code = proc do + Struct.new("A") + Struct.send(:remove_const, :A) + end + + 1_000.times(&code) + PREP + 50_000.times(&code) + CODE + end + class TopStruct < Test::Unit::TestCase include TestStruct |