summaryrefslogtreecommitdiff
path: root/test/ruby
diff options
context:
space:
mode:
authorAlan Wu <XrXr@users.noreply.github.com>2023-01-12 13:30:06 -0500
committerAlan Wu <XrXr@users.noreply.github.com>2023-01-12 15:18:18 -0500
commit537183cd2ac0163851277b46a2f21ea5914c11c0 (patch)
tree8048674b59ff157bf48c4390b6e72bbad9a3d200 /test/ruby
parentda7e5c7b776e8ebbbef97c15305fbad5d032242b (diff)
Fix write barrier order for `klass` to `cme` edge
Previously, the following crashes with `CFLAGS=-DRGENGC_CHECK_MODE=2 -DRUBY_DEBUG=1 -fno-inline`: $ ./miniruby -e 'GC.stress = true; Marshal.dump({})' It crashes with a write barrier (WB) miss assertion on an edge from the `Hash` class object to a newly allocated negative method entry. This is due to usages of vm_ccs_create() running the WB too early, before the method entry is inserted into the cc table, so before the reference edge is established. The insertion can trigger GC and promote the class object, so running the WB after the insertion is necessary. Move the insertion into vm_ccs_create() and run the WB after the insertion. Discovered on CI: http://ci.rvm.jp/results/trunk-asserts@ruby-sp2-docker/4391770
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/7113
Diffstat (limited to 'test/ruby')
0 files changed, 0 insertions, 0 deletions