summaryrefslogtreecommitdiff
path: root/test/ruby
diff options
context:
space:
mode:
authorAlan Wu <XrXr@users.noreply.github.com>2024-04-02 12:29:14 -0400
committerGitHub <noreply@github.com>2024-04-02 12:29:14 -0400
commit3c4de946c9a782c3d993cfa9886f09dba46ece1d (patch)
tree2ac25da99dadafa0575c07e5f9c873d213193315 /test/ruby
parent94f7098d1cafc0a7abd0596b8ecb02cdf1acc3f2 (diff)
YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible (#10402)
* YJIT: A64: Use ADDS/SUBS/CMP (immediate) when possible We were loading 1 into a register and then doing ADDS/SUBS previously. That was particularly bad since those come up in fixnum operations. ```diff # integer left shift with rhs=1 - mov x11, #1 - subs x11, x1, x11 + subs x11, x1, #1 lsl x12, x11, #1 asr x13, x12, #1 cmp x13, x11 - b.ne #0x106ab60f8 - mov x11, #1 - adds x12, x12, x11 + b.ne #0x10903a0f8 + adds x12, x12, #1 mov x1, x12 ``` Note that it's fine to cast between i64 and u64 since the bit pattern is preserved, and the add/sub themselves don't care about the signedness of the operands. CMP is just another mnemonic for SUBS. * YJIT: A64: Split asm.mul() with immediates properly There is in fact no MUL on A64 that takes an immediate, so this instruction was using the wrong split method. No current usages of this form in YJIT. --------- Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
Diffstat (limited to 'test/ruby')
0 files changed, 0 insertions, 0 deletions